JavaScript if else statement with 3 conditions [closed]

Question

Closed. This question does not meet Stack Overflow guidelines. It is not currently accepting answers.

This question does not appear to be about programming within the scope defined in the help center.

Closed 12 years ago.

i don't know why doesn't this work but i think probably because of the statement, Or the testRed and testGreen function conflict with each other. If so, can you please suggest a better way of doing it. Code:

var greenSoldier = 5;
var redSoldier = 5;
var territory = ['green', 'green', 'neutral', 'neutral', 'green', 'neutral', 'neutral', 'neutral', 'neutral', 'neutral', 'neutral', 'red', 'neutral', 'neutral', 'red', 'red'];
var soldier = [4, 2, 0, 0, 2, 0, 0, 0, 0, 0, 0, 2, 0, 0, 2, 4];
var turn = 'green';

function testGreen(itemNumber, soldiers, itemName) {
    if (greenSoldier > 0 && territory[itemNumber] == 'green') {
        var unchanged = soldier[itemNumber];
        var changed = unchanged + 1;
        soldier[itemNumber] = changed;
        $(itemName).html(soldier[itemNumber]);
        greenSoldier -= 1;
        console.log(greenSoldier);
    } else if (greenSoldier > 0 && territory[itemNumber == 'neutral'] && turn == 'green') {
        soldier[itemNumber] += 1;
        console.log(soldier[itemNumber]);
        $(itemName).html(soldier[itemNumber]);
        greenSoldier -= 1;
        console.log(greenSoldier);
    }
}

function testRed(itemNumber, soldiers, itemName) {
    if (redSoldier > 0 && territory[itemNumber] == 'red') {
        var unchanged = soldier[itemNumber];
        var changed = unchanged + 1;
        soldier[itemNumber] = changed;
        $(itemName).html(soldier[itemNumber]);
        redSoldier -= 1;
        console.log(redSoldier);
    } else if (redSoldier > 0 && territory[itemNumber == 'neutral'] && turn == 'red') {
        soldier[itemNumber] += 1;
        $(itemName).html(soldier[itemNumber]);
        redSoldier -= 1;
        console.log(redSoldier);
    }
}
$('#item4').click(

function () {
    testGreen(3, soldier[3], '#item4');
    testRed(3, soldier[3], '#item4');
})

This question appears to be off-topic because it is about spotting a typo. — Matt Ball
– Matt Ball, Commented Nov 24, 2013 at 7:10

Krish R · Accepted Answer · 2013-11-24 07:10:06Z

3

Try using territory[itemNumber] == 'neutral' instead of territory[itemNumber == 'neutral'] in all occurrence in your code

answered Nov 24, 2013 at 7:10

Krish R

22.7k7 gold badges54 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris Hayes · Accepted Answer · 2013-11-24 07:10:13Z

1

else if (redSoldier > 0 && territory[itemNumber == 'neutral'] && turn == 'red')

You goofed up your array access.

else if (redSoldier > 0 && territory[itemNumber] == 'neutral' && turn == 'red')

answered Nov 24, 2013 at 7:10

Chris Hayes

12.2k5 gold badges35 silver badges48 bronze badges

Comments

Community · Accepted Answer · 2020-06-20 09:12:55Z

0

Make sure that your jquery is properly installed. In javaScript, you can declare an array in this manner:

var soldier=new Array(4, 2, 0, 0, 2, 0, 0, 0, 0, 0, 0, 2, 0, 0, 2, 4);

Then on your testGreen/testRed function, try to consider your soldier parameter as an array:

function testRed(itemNumber, soldiers, itemName)

{

//action here.

}

edited Jun 20, 2020 at 9:12

CommunityBot

11 silver badge

answered Nov 24, 2013 at 7:14

RocketArrows1

778 bronze badges

Collectives™ on Stack Overflow

JavaScript if else statement with 3 conditions [closed]

3 Answers 3

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Linked

Related