Remove comma from last array value

Question

PHP

$meta = get_post_custom($post->ID); 
$images = $meta['img1'][0];    // urls separated with comma
$images = explode(',', $images);
foreach ($images as $image) {
    echo '{image : '.$image.', title : "Credit: x"},'; 
};

Output:

{image : 'http://localhost/slideshow/1.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/2.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/3.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/4.jpg', title : 'Credit: x'}, // last comma, just after }

I would like to remove the last commented comma in output.

This is exactly what I'm trying to get:

Desired output:

{image : 'http://localhost/slideshow/1.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/2.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/3.jpg', title : 'Credit: x'},
{image : 'http://localhost/slideshow/4.jpg', title : 'Credit: x'}

How about using the build in PHP functions to generate valid JSON? (json_encode) — Valentin Despa
– Valentin Despa, Commented Nov 26, 2013 at 6:38

Community · Accepted Answer · 2023-11-17 20:42:18Z

You have lots of options:

// Using rtrim
$meta = get_post_custom($post->ID); 
$images = $meta['img1'][0];    // urls separated with comma
$images = explode(',', $images);
$string = '';
foreach ($images as $image) {
    $string .= '{image : '.$image.', title : "Credit: x"},'; 
};
$string = rtrim($string, ',');
echo $string;

// Using substring
$meta = get_post_custom($post->ID); 
$images = $meta['img1'][0];    // urls separated with comma
$images = explode(',', $images);
$string = '';
foreach ($images as $image) {
    $string .= '{image : '.$image.', title : "Credit: x"},'; 
};
$string = substr($string, 0, -1);
echo $string;

// Using implode
$meta = get_post_custom($post->ID); 
$images = $meta['img1'][0];    // urls separated with comma
$images = explode(',', $images);
$stringElements = array();
foreach ($images as $image) {
    stringElements[] = '{image : '.$image.', title : "Credit: x"}'; 
};

$string =  implode(',', $stringElements);
echo $string;

Also consider using a more efficient way to create JSON strings: json_encode.

Viacheslav Kondratiuk · Accepted Answer · 2013-11-26 06:38:29Z

2

You can buffer output into variable and solve this way:

echo rtrim($bufferedData, ',');

But as I can see, it's better for you to use json functions.

answered Nov 26, 2013 at 6:38

Viacheslav Kondratiuk

8,9609 gold badges53 silver badges81 bronze badges

Comments

Alma Do · Accepted Answer · 2013-11-26 06:40:43Z

2

So all your code is about creating JSON from your data. That will be:

$data   = 'http://localhost/slideshow/1.jpg,http://localhost/slideshow/2.jpg,http://localhost/slideshow/3.jpg';
$credit = 'x';
$result = json_encode(array_map(function($image) use ($credit)
{
   return ['image'=>$image, 'Credit'=>$credit];
}, explode(',', $data)));
//var_dump($result);

answered Nov 26, 2013 at 6:40

Alma Do

37.4k10 gold badges81 silver badges106 bronze badges

Comments

TURTLE · Accepted Answer · 2013-11-26 06:58:45Z

1

Maybe this using rtrim()

$images = 'image1.png,image2.png,image3.png';
$ex = explode(',', $images);
foreach ($ex as $image) {
    $image_string .= "{'image' : '{$image}', 'title' : 'Credit: x'},"; 
}

print rtrim($image_string, ',');

Above returns below

{'image' : 'image1.png', 'title' : 'Credit: x'},
{'image' : 'image2.png', 'title' : 'Credit: x'},
{'image' : 'image3.png', 'title' : 'Credit: x'}

edited Nov 26, 2013 at 6:58

answered Nov 26, 2013 at 6:47

TURTLE

3,8624 gold badges54 silver badges55 bronze badges

Collectives™ on Stack Overflow

Remove comma from last array value

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related