Error in string format

Question

I have a method that prints out the total price as a double after calculating the charge and adding a fee to it.

public static String printWarehouseCharge(Warehouse w[])
{
    String wc = "";     
    for(int i=0; i < 4; i++)
    {
        // method that calculates charge and returns a double
        double warehouseCharge = w[i].calculateWarehouseCharge();
        //here the calculateTransportFee method adds a fee and returns the total to be printed
        wc = wc+String.format("$%,.2f",  w[i].calculateTransportFee(warehouseCharge) +"\n");
    }
    return wc;
}

Unfortunately I keep getting a format error: IllegalFormatConversionException. Can anyone help me?

simply your calculateTransportFee method do not return a correct float. — erencan
– erencan, Commented Nov 28, 2013 at 6:56

Buddha · Accepted Answer · 2013-11-28 07:04:59Z

2

The issue is because you are trying to add a number with a string in the below line. w[i].calculateTransportFee(warehouseCharge) +"\n"

what is returned from w[i].calculateTransportFee(warehouseCharge) is a number either float or double and you are addin git it to \n.

This should work for you...

wc = wc+String.format("$%,.2f", w[i].calculateTransportFee(warehouseCharge)) +"\n";

answered Nov 28, 2013 at 7:04

Buddha

4,4742 gold badges32 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sanbhat · Accepted Answer · 2013-11-28 07:01:52Z

1

The problem is argument to the String.format method. Your second argument is expected to be double/float but it is actually String due to concantenation

wc = wc+String.format("$%,.2f",  w[i].calculateTransportFee(warehouseCharge) +"\n");
                                                                          ^^^^^^^^^
                                                        Here is the error because the 2nd argument gets converted into String

Try this

 wc = wc+String.format("$%,.2f",  w[i].calculateTransportFee(warehouseCharge));
 wc+= "\n";

answered Nov 28, 2013 at 7:01

sanbhat

17.6k6 gold badges52 silver badges65 bronze badges

Comments

Masudul · Accepted Answer · 2013-11-28 07:03:46Z

1

The problem is appending +"\n" with double at String.format which is a IllegalFormatConversionException

wc = wc+String.format("$%,.2f", 
    w[i].calculateTransportFee(warehouseCharge)); // Remove "\n"

edited Nov 28, 2013 at 7:03

answered Nov 28, 2013 at 6:56

Masudul

22k5 gold badges45 silver badges60 bronze badges

Comments

sergeyan · Accepted Answer · 2013-11-28 07:05:58Z

1

You might get IllegalFormatConversionException when the argument corresponding to the format specifier is of an incompatible type. In your code you specified that the method 'format' should expect floating point number. You provided not 'warehouseCharge' , but the string 'warehouseCharge + "\n"'. When adding string and a number, the result is always string.

edited Nov 28, 2013 at 7:05

answered Nov 28, 2013 at 7:00

sergeyan

1,1831 gold badge14 silver badges28 bronze badges

Collectives™ on Stack Overflow

Error in string format

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related