php unquoted attribute value

Question

Hi I am trying to create my first REST service and have spent some time reading tutorials, I am following one through and in the client code I am getting a "=" in a unquoted attribute value. in the href line between the last <li> entry. I can't see whats wrong. I would like to get the example working and then build it up for the solution I am working on.

<?php

/*** this is the client ***/

if (isset($_GET["action"]) && isset($_GET["id"]) && $_GET["action"] == "get_user") // if the   get parameter action is get_user and if the id is set, call the api to get the user information
{
 $user_info = file_get_contents('http://localhost/RestServer/api.php?action=get_user&id=' . $_GET ["id"]);
$user_info = json_decode($user_info, true);

// THAT IS VERY QUICK AND DIRTY !!!!!
?>
<table>
  <tr>
    <td>Name: </td><td> <?php echo $user_info["last_name"] ?></td>
  </tr>
  <tr>
    <td>First Name: </td><td> <?php echo $user_info["first_name"] ?></td>
  </tr>
  <tr>
    <td>Age: </td><td> <?php echo $user_info["age"] ?></td>
  </tr>
</table>
<a href="http://localhost/RestClient/index.php?action=get_userlist" >Return to the user list</a>
<?php
}
else // else take the user list
{
$user_list = file_get_contents('http://localhost/RestServer/api.php?action=get_user_list');
$user_list = json_decode($user_list, true);
// THAT IS VERY QUICK AND DIRTY !!!!!
?>
<ul>
<?php foreach ($user_list as $user): ?>
  <li>
    <a href=<?php echo "http://localhost/RestClient/index.php?action=get_user&id=" . $user   ["id"]  ?> alt=<?php echo "user_" . $user_["id"] ?>><?php echo $user["name"] ?></a>
</li>
<?php endforeach; ?>
</ul>
<?php
}
?>

<a href=<?php echo it's unquoted because you don't have quotes after href= — Nick R
– Nick R, Commented Nov 29, 2013 at 10:48

Tom Chung · Accepted Answer · 2013-11-29 10:45:38Z

1

<a href="<?php echo "http://localhost/RestClient/index.php?action=get_user&id=" . $user   ["id"]  ?>" alt="<?php echo "user_" . $user_["id"] ?>"><?php echo $user["name"] ?></a>

OR

<a href=<?php echo "'http://localhost/RestClient/index.php?action=get_user&id=" . $user   ["id"]."'"  ?> alt=<?php echo "'user_" . $user_["id"]."'" ?>><?php echo $user["name"] ?></a>

answered Nov 29, 2013 at 10:45

Tom Chung

1,4229 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

SagarPPanchal · Accepted Answer · 2013-11-29 11:00:16Z

1

I have updated your code, and it works well

<?php echo "<a href='http://localhost/RestClient/index.php?action=get_user&id='".$user['id']."' alt=user_'".$user['id']."'>"; ?><?php echo $user["name"] . "</a>"; ?>

answered Nov 29, 2013 at 11:00

SagarPPanchal

10.2k6 gold badges36 silver badges66 bronze badges

Comments

M.B Kakadiya · Accepted Answer · 2013-11-29 11:05:11Z

0

May be helpful.

<a herf="http://localhost/RestClient/index.php?action=get_user&id="<?php echo $user["id"]; ?> alt="user_"<?php echo $user_["id"]; ?> > <?php echo $user["name"]; ?> </a>

or

<a herf="http://localhost/RestClient/index.php?action=get_user&id=<?php echo $user['id']; ?>" alt="user_<?php echo $user_['id']; ?>" > <?php echo $user["name"]; ?> </a>

answered Nov 29, 2013 at 11:05

M.B Kakadiya

5761 gold badge5 silver badges18 bronze badges

Collectives™ on Stack Overflow

php unquoted attribute value

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related