A javascript filter using a for/in loop?

Question

Is it possible to filter a javascript array? I've taken the following approach but it doesn't seem to produce the intended results.

Arrays:

var catalog1 = [0]
var catalog2 = [1]
var products = [{ id: "PRODUCTA", desc: "Toys" },
                { id: "PRODUCTB", desc: "Cars" }]

Filter:

var NewProducts = [];
for (r in catalog1) NewProducts.push(products[r]);

NewProducts should contain either product A or B depending on which catalog array is selected. My attempt always return product A, as in r = 0. What am I missing?

http://jsfiddle.net/rE52f/

In the code you've posted, you're always processing catalog1. — Ted Hopp
– Ted Hopp, Commented Nov 29, 2013 at 17:25
@TedHopp yes, I simplified it but in my code there a condition which sets the catalog. In the fiddle, you can see that if you use catalog2, it returns product A, not B. — greener
– greener, Commented Nov 29, 2013 at 17:27
for (r in catalog1) is not the correct way to iterate over an array. — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Nov 29, 2013 at 17:33

Ingo Bürk · Accepted Answer · 2013-11-29 17:30:24Z

4

It is because Javascript's for each loop generates the keys of your collection. You will have to change it to:

for (var r in someCatalogue) NewProducts.push(products[someCatalogue[r]]);

You can also use map inside a closure, if you don't have to support IE8 and less:

(function(products) {
  NewProducts = someCatalogue.map(function(item) { return products[item]; });
})(products);

edited Nov 29, 2013 at 17:30

Ingo Bürk

20.2k7 gold badges72 silver badges103 bronze badges

answered Nov 29, 2013 at 17:27

Domi

24.9k19 gold badges104 silver badges133 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ibrahim Najjar · Accepted Answer · 2013-11-29 17:38:17Z

2

It is possible to filter a JavaScript array, just use the filter method:

var arr = [1, 2, 3, 4, 5, 6];
var result = arr.filter(function(item) {
        return item > 3;
    }
);

In your situation you are trying to filter the products array to include certain elements, so to do it the right way:

var catalog1 = [0];
var catalog2 = [1];
var products = [{ id: "PRODUCTA", desc: "Toys" },
            { id: "PRODUCTB", desc: "Cars" }];

var NewProducts = products.filter( function(item) {
        // check item and if it is accepted then include it.
    }
);

In your code, you are using for/in to loop the array elements which is not the right way to walk the array, use a regular for loop:

var NewProducts = [];
for (var i=0; i<catalog1.length; i++) NewProducts.push(products[catalog1[i]]);

edited Nov 29, 2013 at 17:38

answered Nov 29, 2013 at 17:24

Ibrahim Najjar

19.5k4 gold badges74 silver badges96 bronze badges

Collectives™ on Stack Overflow

A javascript filter using a for/in loop?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related