Use variables in different methods?

Question

At this time I need to use three variables in three different methods with the respective file in the view, but I don't want to define each variable in each method.

How can I define the variable just once and have access to the variables from all the three methods?

Those are the methods:

def pendientes
end

def proceso
end

def finalizadas
end

Those are the three variables:

@pendientes     = Support.where("estado = ?", 1)
@procesos       = Support.where("estado = ?", 2)
@finalizadas    = Support.where("estado = ?", 3)

How do I need to define the variables to do it?

Why don't you want to define each variable in each method? Are you having refactoring problems? — thank_you
– thank_you, Commented Nov 29, 2013 at 18:21
Is just because I dont want to define it in each method, I think is better to do it with another way, with less code — Andru1989
– Andru1989, Commented Nov 29, 2013 at 18:31

Michael Stalker · Accepted Answer · 2013-11-30 14:38:59Z

3

If you're working in the context of a controller, you could do something like this:

class MyController < ApplicationController
  before_filter :initialize_variables

  def pendientes
  end

  def proceso
  end

  def finalizadas
  end

  private

    def initialize_variables
      @pendientes = Support.where(estado: 1)
      @procesos = Support.where(estado: 2)
      @finalizadas = Support.where(estado: 3)
    end
end

Update:

If you roll with a before_filter, it may be a good idea to add only: [:pendientes, :proceso, :finalizadas] so that future actions added to the controller don't initialize the three variables.

Another option would be to delete the before_filter call and just invoke the initialize_variables method from each of the three existing actions.

edited Nov 30, 2013 at 14:38

answered Nov 29, 2013 at 19:02

Michael Stalker

1,3679 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Billy Chan Over a year ago

I don't think before_filter is the right case here. What if more actions to be added in this controller? You'll add unnecessary burdens to them. Then use :only to separate them?

Michael Stalker Over a year ago

:only would work. I don't think the extra database calls would add much burden if more actions got added, though. It may have been better to just call initialize_variables from each of the three actions that currently exist. I'll update my answer to mention the alternatives.

Collectives™ on Stack Overflow

Use variables in different methods?

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related