Challenges with mysql_fetch_array()

Question

I'm running into a situation where a mysql_query() result being fed into a mysql_fetch_array() function is being interpreted as a boolean instead of the result.

The below code uses Using an SQL result in a foreach loop as a coding example for doing a foreach loop. There may be multiple problems with the code still as my current problem occurs before the foreach loop.

$results=mysql_query("SELECT * FROM order_details WHERE orderid = $orderid");

    print "SELECT * FROM order_details WHERE orderid = $orderid";

    $productid;
    $quantity;
    $price;

    $resultset = array();
while ($row = mysql_fetch_arraY($results)) {
$resultset[] = $row;
}

    foreach ($resultset as $result)
    {

    $productid = $result['productid'];
    $quantity = $result['quantity'];
    $price = $result['price'];

    print "<br />$productid, $quantity, $price";
    };

It is not “interpreted as boolean” – it simply is boolean false, because your query has an error. Use mysql_error() to find out what it is. — C3roe
– C3roe, Commented Dec 4, 2013 at 23:22
By building SQL statements with outside variables, you are leaving yourself wide open to SQL injection attacks. Also, any input data with single quotes in it, like a name of "O'Malley", will blow up your SQL query. Please learn about using parametrized queries, preferably with the PDO module, to protect your web app. bobby-tables.com/php has examples to get you started, and this question has many examples in detail. — Andy Lester
– Andy Lester, Commented Dec 5, 2013 at 17:24
Thank you, I realize that this is not perfect. But is just some quick code for a PHP class. I would most certainly sanitize my strings in a real world environment. :) — Spitfire19
– Spitfire19, Commented Dec 8, 2013 at 6:00

Prashant G · Accepted Answer · 2013-12-04 23:24:28Z

0

Change $orderid to '$orderid' provided that everything is fine. One big note, try going over mysqli and PDO instead of mysql.

answered Dec 4, 2013 at 23:24

Prashant G

4,9303 gold badges38 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Spitfire19 · Accepted Answer · 2013-12-05 17:01:30Z

0

for($i=0;$i<$max;$i++) {
        $pid=$_SESSION['cart'][$i]['productid'];
        $q=$_SESSION['cart'][$i]['qty'];
        $price=get_price($pid);

        $pname;

        $row = mysql_fetch_assoc(mysql_query("SELECT name\n"
        . "FROM `products` \n"
        . "WHERE SERIAL =$pid\n"
        . "LIMIT 1"));
        $pname = $row['name'];

        print "<br  />Product Name: $pname, Quantity: $q, Price: $price";
    }

answered Dec 5, 2013 at 17:01

Spitfire19

4001 gold badge2 silver badges12 bronze badges

Collectives™ on Stack Overflow

Challenges with mysql_fetch_array()

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related