Regex preg_replace find image in string WITH img attributes

Question

I'm trying to find ALL images in my blog posts with regex. The code below returns images IF the code is clean and the SRC tag comes right after the IMG tag. However, I also have images with other attributes such as height and width. The regex I have does not pick that up... Any ideas?

The following code returns images that looks like this:

<img src="blah_blah_blah.jpg">

But not images that looks like this:

<img width="290" height="290" src="blah_blah_blah.jpg">

Here is my code

$pattern = '/<img\s+src="([^"]+)"[^>]+>/i';

preg_match($pattern, $data, $matches);

echo $matches[1];

Why don't you parse the HTML using something like SimpleHTMLDOM and then grab the IMG tags that way? It's more reliable — kinghfb
– kinghfb, Commented Dec 6, 2013 at 16:03

hwnd · Accepted Answer · 2013-12-06 16:41:31Z

4

Use DOM or another parser for this, don't try to parse HTML with regular expressions.

$html = <<<DATA
<img width="290" height="290" src="blah.jpg">
<img src="blah_blah_blah.jpg">
DATA;

$doc = new DOMDocument();
$doc->loadHTML($html); // load the html

$xpath = new DOMXPath($doc);
$imgs  = $xpath->query('//img');

foreach ($imgs as $img) {
   echo $img->getAttribute('src') . "\n";
}

Output

blah.jpg
blah_blah_blah.jpg

edited Dec 6, 2013 at 16:41

answered Dec 6, 2013 at 16:08

hwnd

70.9k4 gold badges100 silver badges135 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

2famous.TV Over a year ago

Wow, thanks! I love the solution, and it works perfectly well. I'm learning a lot, and reading up on DOM parsing! Thanks!

Lenny Over a year ago

Yup, and it's much safer than regex too.

Lenny · Accepted Answer · 2013-12-06 16:15:17Z

3

Ever think of using the DOM object instead of regex?

$doc = new DOMDocument();
$doc->loadHTML('<img src="http://example.com/img/image.jpg" ... />');
$imageTags = $doc->getElementsByTagName('img');

foreach($imageTags as $tag) {
    echo $tag->getAttribute('src');
}

edited Dec 6, 2013 at 16:15

answered Dec 6, 2013 at 16:06

Lenny

5,9872 gold badges21 silver badges27 bronze badges

1 Comment

2famous.TV Over a year ago

Thanks, I had no idea that I could parse like this! Thanks, learning some PhP every day!

Toto · Accepted Answer · 2013-12-06 16:04:29Z

1

You'd better to use a parser, but here is a way to do with regex:

$pattern = '/<img\s.*?src="([^"]+)"/i';

answered Dec 6, 2013 at 16:04

Toto

91.7k63 gold badges97 silver badges135 bronze badges

Comments

elixenide · Accepted Answer · 2013-12-06 16:07:44Z

1

The problem is that you only accept \s+ after <img. Try this instead:

$pattern = '/<img\s+[^>]*?src="([^"]+)"[^>]+>/i';

preg_match($pattern, $data, $matches);

echo $matches[1];

answered Dec 6, 2013 at 16:07

elixenide

44.9k16 gold badges79 silver badges103 bronze badges

Comments

izn · Accepted Answer · 2013-12-06 16:09:33Z

1

Try this:

$pattern = '/<img\s.*?src=["\']([^"\']+)["\']/i';

Single or double quote and dynamic src attr position.

answered Dec 6, 2013 at 16:09

izn

3101 silver badge7 bronze badges

Collectives™ on Stack Overflow

Regex preg_replace find image in string WITH img attributes

5 Answers 5

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related