If condition not working in JAVASCRIPT

Question

I have three buttons, + value -. in this when i click + button value will increase and - value will be decrease .. i have wote the code in jSFIDLLE. it working.

And the value should not be minus. so i added one if condition. then my code is not working.

html-

<input type="Button" id='AddButton' value="+" />
<input type="Button" id='BoqTextBox' value="0" />
<input type="Button" id='MinusButton' value="-" />

javascript -

$('#AddButton').on('click', function () {
    var input = $('#BoqTextBox');
    input.val(parseFloat(input.val(), 10) + 1);
})
$('#MinusButton').on('click', function () {    
  var input = $('#BoqTextBox');
    if(input>0)
    { input.val(parseFloat(input.val(), 10) - 1);}
})

input is an object, a jQuery object. What makes you think it will be greater than 0? — fbynite
– fbynite, Commented Dec 9, 2013 at 7:36

Raul Rene · Accepted Answer · 2013-12-09 07:37:12Z

2

You are comparing a HTML element with 0. You need to compare its value with 0

Try

if (input.val() > 0)

answered Dec 9, 2013 at 7:37

Raul Rene

10.3k9 gold badges56 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2976089 · Accepted Answer · 2013-12-09 07:39:27Z

2

You need to use

if(input.val() > 0)

As

if(input > 0)

Means that you are trying to see if the object, not it's value is bigger than 0, which is not the case as it is an element

answered Dec 9, 2013 at 7:39

user2976089

3551 gold badge5 silver badges16 bronze badges

Comments

Krish R · Accepted Answer · 2013-12-09 07:36:53Z

1

Use if(input.val()>0) instead of if(input>0)

answered Dec 9, 2013 at 7:36

Krish R

22.7k7 gold badges54 silver badges60 bronze badges

Comments

Aurélien Gasser · Accepted Answer · 2013-12-09 07:38:10Z

1

You are trying to compare input with 0. You should instead compare the value of input with 0.

Replace

if (input > 0)

with

if (parseInt(input.val()) > 0)

answered Dec 9, 2013 at 7:38

Aurélien Gasser

3,1201 gold badge23 silver badges25 bronze badges

2 Comments

Sagotharan Over a year ago

is parseInt need to add,. input.val() gives output, and parseInt(input.val() also. what is the use of parseInt?

Aurélien Gasser Over a year ago

The difference is the type of the result: input.val() equals the string "1" whereas parseInt(input.val()) equals the number 1. It works if you omit to call parseInt() because javascript is smart : when it compares the string "1" and the integer 0, it understands that the string is, in fact, an integer.

user2009750 · Accepted Answer · 2013-12-09 07:43:36Z

1

Here it is

$('#AddButton').on('click', function () {
    var input = $('#BoqTextBox');
    input.val(parseFloat(input.val(), 10) + 1);
})
$('#MinusButton').on('click', function () {    
  var input = $('#BoqTextBox');
    if(input.val()>0)
    { input.val(parseFloat(input.val(), 10) - 1);}
})

answered Dec 9, 2013 at 7:43

user2009750

3,1976 gold badges37 silver badges58 bronze badges

Comments

Merlin · Accepted Answer · 2013-12-09 07:44:34Z

1

Try this:

if(input.val() > 0)

edited Dec 9, 2013 at 7:44

answered Dec 9, 2013 at 7:38

Merlin

4,9252 gold badges35 silver badges53 bronze badges

Collectives™ on Stack Overflow

If condition not working in JAVASCRIPT

6 Answers 6

Comments

Comments

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related