javascript form validation with multiple if statements

Question

is this form validation function correct? or it can be done better ?
For example: I want one of the two drop-downs to have a value before checking the contact details fields, (dp1 OR dp2) but even though using ( || ) the validation is acting as &&.

$('#send').click(function(){

if( document.downloadForm.SoftwareDp.value == "0" || document.downloadForm.ManualDp.value == "0" )
{
 alert( "Please Select a file for Download" );
 return false;  }

// First check if Dropdown 1 OR dropdown 2 have been selected ( ONE at least)


if( document.downloadForm.name.value == "" && document.downloadForm.email.value == "" )
{
 alert( "Please enter your details" );
 return false;  }

 // then check if name and email are typed in.

 else{ // run some ajax if above conditions are met } });

Demo : http://jsbin.com/UGotAFIL/1/edit?html,js,output Thanks

You could use jquery validation plugin for form validation. It will more easy use. jqueryvalidation.org/validate — CJ Ramki
– CJ Ramki, Commented Dec 13, 2013 at 10:09
First default option <option value="0">Software</option> ect... then other options have value... — Awena
– Awena, Commented Dec 13, 2013 at 10:10
Take a look at this jsbin.com/IRiCases/1/edit why do you think that || is acting like a && ? it works fine. — Tiberiu C.
– Tiberiu C., Commented Dec 13, 2013 at 10:15
@tiberiu.corbu, Thanks, but it is not. check the edited version... — Awena
– Awena, Commented Dec 13, 2013 at 10:25

CJ Ramki · Accepted Answer · 2013-12-13 10:42:32Z

3

Your condition working perfectly. If you want to check both drop down are not selected you should use && instead of ||.

If you need to select at least one drop down means you can you can use

 $('#send').click(function(){

if(!( document.downloadForm.SoftwareDp.value != "0" || document.downloadForm.ManualDp.value != "0" ))
{
 alert( "Please Select a file for Download" );
 return false;  }

// First check if Dropdown 1 OR dropdown 2 have been selected ( ONE at least)


if( document.downloadForm.name.value === "" && document.downloadForm.email.value === "" )
{
 alert( "Please enter your details" );
 return false;  }

 // then check if name and email are typed in.

 else{ // run some ajax if above conditions are met 
 } });

see this jsbin demo

answered Dec 13, 2013 at 10:42

CJ Ramki

2,6323 gold badges27 silver badges47 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user1950929 · Accepted Answer · 2013-12-13 10:39:18Z

0

If I understand you correctly, you want to show the error when no dropdown has a value, that is both have no value. Change

if( document.downloadForm.SoftwareDp.value == "0" || document.downloadForm.ManualDp.value == "0" )

to either

if( document.downloadForm.SoftwareDp.value == "0" && document.downloadForm.ManualDp.value == "0" ) // both have the default value 0

or

if(!( document.downloadForm.SoftwareDp.value != "0" || document.downloadForm.ManualDp.value != "0" )) // none of them has not the default value

answered Dec 13, 2013 at 10:39

user1950929

8641 gold badge9 silver badges18 bronze badges

Comments

A.R · Accepted Answer · 2013-12-13 10:55:11Z

0

The way you are checking will always give alert unless you select other than 0 values in both.

You should do it this way:

if( document.downloadForm.SoftwareDp.value == "0" && document.downloadForm.ManualDp.value == "0" )

The above will give alert only when both are selected for 0. If one of them has other value it won't display alert.

answered Dec 13, 2013 at 10:55

A.R

4079 silver badges25 bronze badges

Collectives™ on Stack Overflow

javascript form validation with multiple if statements

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related