JQuery function is not defined

Question

this.slideUpComm = function (){
    $("#Day-events-content p").addClass("hidden").slideUp("fast");
} 
this.showhideEvents = function() {
    $("#Day-events-content").on("click", ".eventsToggle", function() {
        var obj = $(this).next();
        if ($(obj).hasClass("hidden")) {
            slideUpComm();
            $(obj).removeClass("hidden").slideDown();
        } else {
            $(obj).addClass("hidden").slideUp();
        }
    });
}

I would like to use slideUpComm as function that I include on different events but console return Uncaught ReferenceError: slideUpComm is not defined. How I should pass function to function ? Should I use callback?

function dateObj() {
this.d = new Date();
this.day = this.d.getDate();
this.numDay = this.d.getDay();
this.month = parseInt(this.d.getMonth());
this.year = this.d.getFullYear();

this.slideUpComm = function (){

} 
this.showhideEvents = function() {

});
}
}

My Object look like above.

What is this, and how are you calling the function?

Rory McCrossan
– Rory McCrossan

2013-12-16 09:24:25 +00:00
Commented Dec 16, 2013 at 9:24 — Rory McCrossan
– Rory McCrossan, Commented Dec 16, 2013 at 9:24

Arun P Johny · Accepted Answer · 2013-12-16 09:24:51Z

2

The problem is slideUpComm is a member of an object... so you need to use the object reference to invoke the method

//create a closure varaible to hold the reference to the instance
var self = this;
this.slideUpComm = function (){
    $("#Day-events-content p").addClass("hidden").slideUp("fast");
} 
this.showhideEvents = function() {
    $("#Day-events-content").on("click", ".eventsToggle", function() {
        var obj = $(this).next();
        if ($(obj).hasClass("hidden")) {
            //slideUpComm is a instance property so access it using the instance
            self.slideUpComm();
            $(obj).removeClass("hidden").slideDown();
        } else {
            $(obj).addClass("hidden").slideUp();
        }
    });
}

answered Dec 16, 2013 at 9:24

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Dalli Over a year ago

Thank You for Your help.I would like to ask is this way that I used it's appropriate of creating obj in JS? I mean best practice.

Raunak Kathuria · Accepted Answer · 2013-12-16 09:35:33Z

1

slideUpComm is a function of dateObj, you can not directly invoke the function. So to invoke a function you need to create an instance of function/object

var a = new dataObj();

then you can invoke the function using

a.slideUpComm()

answered Dec 16, 2013 at 9:35

Raunak Kathuria

3,2351 gold badge20 silver badges27 bronze badges

1 Comment

Raunak Kathuria Over a year ago

@arun-p-johny answer is correct, my answer was relevant when function invocation was not added to the question

DarrylGodden · Accepted Answer · 2013-12-16 09:28:29Z

0

Could this not be reduced to:

$("<object>").slideToggle();

?

answered Dec 16, 2013 at 9:28

DarrylGodden

1,5325 gold badges26 silver badges46 bronze badges

1 Comment

Dalli Over a year ago

I think it's going to be shorter and clean.

Collectives™ on Stack Overflow

JQuery function is not defined

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related