jQuery variable (select in html)

Question

I'm new in Jquery, and I have this code:

jQuery(document).ready(function(){
        var title = jQuery(".fullVisaImg").attr("inselect");

        var links = jQuery(".ff_elem>option");

        for(var i=0; i<links.length; i++) {
            if (title == links[i].value) {
                links[i].attr("selected", "selected"); // here is my problem
                alert(links[i].value);
                return;
            }
        }
    });

i have a select element on my pages, and want to make one of elements selected. if I comment line with // here... all works good, and i see all my option values.

Thanks for help!

If you just need 1 element selected then why are you looping over all the options and marking them as selected. Why not use html attribute selected in your markup? — Lucky Soni
– Lucky Soni, Commented Dec 18, 2013 at 13:51
i hope it's not because of missing closing quote; anyway, why not use .val()? — Igor Dymov
– Igor Dymov, Commented Dec 18, 2013 at 13:52
links.eq(i).attr("selected", "selected"); Thanks A. Wolff ! — Andrew Evt
– Andrew Evt, Commented Dec 18, 2013 at 13:57

Gabriele Petrioli · Accepted Answer · 2013-12-18 13:57:00Z

2

When you use [] to access an element in a jquery set, you get back the raw DOM element. So you can not use jquery methods on it directly..

You should also use .prop instead of .attr() when interacting with properties of the element

So use

links.eq(i).prop("selected", true);

answered Dec 18, 2013 at 13:57

Gabriele Petrioli

197k35 gold badges275 silver badges331 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mehran Hatami · Accepted Answer · 2013-12-18 14:09:11Z

2

replace you for loop with:

jQuery(".ff_elem").val(title);

I have created this DEMO for you. Check it out.

Although You can iterate through all your option elements and find your option element, and then do this:

links[i].prop("selected", true);

but there is no need to iterate when you can simply let your select element do this for you as I have mentioned above.

edited Dec 18, 2013 at 14:09

answered Dec 18, 2013 at 13:58

Mehran Hatami

13k6 gold badges31 silver badges36 bronze badges

Comments

epascarello · Accepted Answer · 2013-12-18 14:06:34Z

1

This is actually how you can select an option based on the value your options have.

$('select').val('value of the option you want to select');

so use

$(".ff_elem").val(title);

edited Dec 18, 2013 at 14:06

epascarello

208k20 gold badges206 silver badges246 bronze badges

answered Dec 18, 2013 at 13:53

Andy

3,0222 gold badges28 silver badges34 bronze badges

3 Comments

Gerard Rovira Over a year ago

He's looking for a working solution to links[i].attr("selected", "selected");

epascarello Over a year ago

Why do you keep editing it and breaking the correct way to mark up code?

Andy Over a year ago

@epascarello Sorry, i didn't even get why you would add 4 spaces to my answer, probably because i forgot them...

A. Wolff · Accepted Answer · 2013-12-18 13:57:17Z

0

Following your code, you could use:

links.eq(i).prop("selected", true);

answered Dec 18, 2013 at 13:57

A. Wolff

74.4k9 gold badges98 silver badges158 bronze badges

2 Comments

epascarello Over a year ago

My guess is you have zero explanation about the reason for the error unlike the one right below that explained the error.

A. Wolff Over a year ago

@epascarello ya, sorry about that!

BlackPOP · Accepted Answer · 2013-12-18 13:58:53Z

0

if your jquery version is above 1.6+ then use this

links.eq(i).prop("selected", true);

else

   links.eq(i).attr("selected", "selected");

answered Dec 18, 2013 at 13:58

BlackPOP

5,7572 gold badges36 silver badges49 bronze badges

Comments

Zoltan.Tamasi · Accepted Answer · 2013-12-18 13:59:40Z

0

It can be much simpler. Try something like this:

jQuery(document).ready(function(){
    var title = jQuery(".fullVisaImg").attr("inselect");

    jQuery(".ff_elem>option[value=" + title + "]").attr("selected", "selected");
});

answered Dec 18, 2013 at 13:59

Zoltan.Tamasi

1,38913 silver badges27 bronze badges

3 Comments

epascarello Over a year ago

Should be prop() with modern versions of jQuery

Andy Over a year ago

This is far from simple, as it can be done simpler with jQuery.

Zoltan.Tamasi Over a year ago

It is still simpler than running a for loop to find 'title'.

reergymerej · Accepted Answer · 2013-12-18 13:56:31Z

-2

links is a jQuery collection. When you loop through it, you're just getting the raw element, not a jQuery wrapped version, so you can't use .attr().

Use this instead at your problem line.

$(links[i]).attr("selected", "selected");

answered Dec 18, 2013 at 13:56

reergymerej

2,4172 gold badges27 silver badges32 bronze badges

Collectives™ on Stack Overflow

jQuery variable (select in html)

7 Answers 7

Comments

Comments

3 Comments

2 Comments

Comments

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

Comments

Comments

3 Comments

2 Comments

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related