PHP tags and quotes in variables causing syntax/parse errors

Question

These lines are causing a syntax/parse error, and I'm not sure how to fix it. I'm pretty sure it's either the <?php and ?> tags, or the single quotes. Any ideas?

$data = '<?php
    $title = "'. $name. '";
    $keywords = "'. $title. ','. $developer. '";
    $description = "How to install '. $title. ' for PC and Mac.";

    include('templates/modheader.php');
    include('templates/modfooter.php');
    ?>';

Thanks in advance.

It's more likely to be the fact that you're not escaping the ' around your included filenames — Mark Baker
– Mark Baker, Commented Dec 18, 2013 at 23:53
@arielcr It's a variable to create a file. Yes, the formatting is a bit strange. — swiftsly
– swiftsly, Commented Dec 18, 2013 at 23:57
Nothing about this looks like anything a sane person should ever actually put into production. Stop. Rethink. Rewrite. — Sammitch
– Sammitch, Commented Dec 19, 2013 at 0:05

Eugen Rieck · Accepted Answer · 2013-12-18 23:53:45Z

3

include('templates/modheader.php');
include('templates/modfooter.php');

is the culprit: You mix single quotes. SImply use

include("templates/modheader.php");
include("templates/modfooter.php");

answered Dec 18, 2013 at 23:53

Eugen Rieck

65.6k10 gold badges75 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Lithilion · Accepted Answer · 2013-12-18 23:55:02Z

0

include('templates/modheader.php');
include('templates/modfooter.php');

should be

include("templates/modheader.php");
include("templates/modfooter.php");

answered Dec 18, 2013 at 23:55

Lithilion

1,1292 gold badges11 silver badges26 bronze badges

Comments

Phil · Accepted Answer · 2013-12-18 23:59:17Z

0

For large blocks of string data, I highly recommend the HEREDOC / NOWDOC syntax. You can combine that with sprintf to inject values

$template = <<<'_PHP'
<?php
$title = '%s';
$keywords = $title . ',%s';
$description = "How to install $title for PC and Mac.";

include 'templates/modheader.php';
include 'templates/modfooter.php';
?>
_PHP;

$data = sprintf($template, $name, $developer);

answered Dec 18, 2013 at 23:59

Phil

166k25 gold badges265 silver badges269 bronze badges

Collectives™ on Stack Overflow

PHP tags and quotes in variables causing syntax/parse errors

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related