How boolean condition works in javascript?

Question

I am creating same if else function on my program. And I want to make it more short but same logic.

if(!checkStringInput("Test", 14)){
     elementHasError($element);
} else {
     elementIsOk($element);
}

I am thinking this boolean condition can be a shorter one to:

CONDITION ? FUNCTION1; : FUNCTION2;

Thanks for the help!

Why make it shorter when the code gets less readable (maintainable)? — Ed Heal
– Ed Heal, Commented Dec 20, 2013 at 5:33
@edHeal - Sorry for that. But that whole code is always using. For me, it is a bit messy and I want something more short if calling it 10 times on my code. — grldtcsn
– grldtcsn, Commented Dec 20, 2013 at 5:48

Sachin Jain · Accepted Answer · 2013-12-20 05:33:02Z

3

Have you tried this

!checkStringInput("Test", 14)) ? elementHasError($element) : elementIsOk($element);

answered Dec 20, 2013 at 5:33

Sachin Jain

21.9k34 gold badges113 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

grldtcsn Over a year ago

Thanks! I am doing the wrong way on using this logic. I have ';' on both functions. Thank you for this information. Now it works.

Sachin Jain Over a year ago

Glad to help even if it some small ;)

user703016 · Accepted Answer · 2013-12-20 05:34:36Z

3

Probably the shortest possible:

(checkStringInput("Test", 14) ? elementIsOk : elementHasError)($element);

answered Dec 20, 2013 at 5:34

user703016

38.2k10 gold badges91 silver badges113 bronze badges

4 Comments

Bergi Over a year ago

Well, you could omit a few whitespaces :-) Actually this even looks clean, +1!

Sachin Jain Over a year ago

I like this approach but it may cause issues when the handler needs to be called in some context. For example: (checkStringInput("Test", 14) ? this.elementIsOk : this.elementHasError)($element); Well in this case, conetxt gets lost. OP can use this as well because he does not need any context in the method.

user703016 Over a year ago

@blunderboy (checkStringInput("Test", 14) ? elementIsOk : elementHasError).call(this, $element);

Sachin Jain Over a year ago

@Purrfection I know there are more alternatives to this (like bind). I just wanted to make a point to the readers. Thanks anyway :)

Jayantha Lal Sirisena · Accepted Answer · 2013-12-20 05:33:20Z

0

!checkStringInput("Test", 14)? elementHasError($element): elementIsOk($element);

answered Dec 20, 2013 at 5:33

Jayantha Lal Sirisena

21.4k11 gold badges74 silver badges94 bronze badges

Comments

MultiplyByZer0 · Accepted Answer · 2013-12-20 05:35:53Z

0

You seemed to have it correct. Were you looking for something else beyond the terniary operation?

!checkStringInput('Test', 14) ? elementHasError($element) : elementIsOk($element);

edited Dec 20, 2013 at 5:35

MultiplyByZer0

7,2693 gold badges35 silver badges49 bronze badges

answered Dec 20, 2013 at 5:34

Zach Shallbetter

1,9216 gold badges23 silver badges38 bronze badges

Collectives™ on Stack Overflow

How boolean condition works in javascript?

4 Answers 4

2 Comments

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related