0

In the success callback of an ajax request, I get one object, which is an array of objects (poList). I want to loop through this list and if the status property is something, then do something.

In the example below, response.PoList is a valid array object with two items in it and x is 0 (in the debugger, I can hover over PoList and it works); however, the status is doesn't exist (i.e., this if statement is always false). What am I doing wrong here

for (var x = 0; x < response.PoList.length; x++) {
    if (response.PoList[x].Status == 'Not edited') {
        response.PoList[x].StatusNum = 1;
    } else {
        response.PoList[x].StatusNum = 3
    }
}

Edit

See screenshot below, I don't think it's a case-sensitivity issue. So, what's highlighted is response.PoList (not just response), x is currently 0, and if I hover over Status, I get nothing (no "undefined" tooltip or anything)

enter image description here

Improve this question
3
  • 3
    You use two different capitalization styles in your post and code for poList and status. javascript is case-sensitive. Is it a capitalization problem? Commented Dec 20, 2013 at 17:15
  • The for loop looks right. It could be worth checking if Status property exists before checking its value. Commented Dec 20, 2013 at 17:16
  • Added the screenshot, I don't believe it's a case sensitivity issue, just an oversight when I was typing the question. Commented Dec 20, 2013 at 19:39

3 Answers 3

Reset to default
2

Your code works as provided - what depends is whether it actually matches your data.

Live Demo

I made this example based on your code. If your response object is different, then, yes, you're doing something wrong.

Also, I'd echo Mr. Zimmerman's comment; this could easily be a capitalization issue.

response = {
    PoList: [
        { 
            foo: 'bar',
            Status: 'edited'
        },
        { 
            foo: 'baz',
            Status: 'Not edited'
        },
        { 
            foo: 'barbar',
            Status: 'Not edited'
        }
    ]
};

for (var x = 0; x < response.PoList.length; x++) {
    if (response.PoList[x].Status === 'Not edited') {
        response.PoList[x].StatusNum = 1;
    } else {
        response.PoList[x].StatusNum = 3;
    }
}
Improve this answer
Sign up to request clarification or add additional context in comments.

4 Comments

Interesting... I feel like mine is doing just that, but it's not working the same.
Can you paste in the exact response object you're dealing with to your question? (Just use JSON.stringify() on it to get a copyable version.)
Yeah, your code is working fine on the response you just pasted, Tom. My updated fiddle has the second item duplicated, but with the Status property changed to 'Not edited', just like in your code, and it properly sets the StatusNum to 1.
Very weird! I'll see if I can put together a broken fiddle.
0

Check for the existance of response.PoList[x].Status:

for (var x = 0; x < response.PoList.length; x++) {
  if (response.PoList[x].Status && response.PoList[x].Status == 'Not edited') {
    response.PoList[x].StatusNum = 1;
  } else {
    response.PoList[x].StatusNum = 3
  }
}

Fiddle

Improve this answer

Comments

0

You're missing a semicolon here response.PoList[x].StatusNum = 3. Other than that, I don't see anything wrong with the code provided, so PoList's variable Status must not be set in the response.

Improve this answer

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.