php code is not executing?

Question

<?php
class abhi
{
    var $contents="default_abhi";

    function abhi($contents)
    {
        $this->$contents = $contents;
    }

    function get_whats_there()
    {
        return $this->$contents;
    }

}

$abhilash = new abhi("abhibutu");
echo $abhilash->get_whats_there();

?>

i've initialized variable contents a default and also constructor, why is the value not printing, anything i should correct here?

see the error,

abhilash@abhilash:~$ php5 pgm2.php 

Fatal error: Cannot access empty property in /home/abhilash/pgm2.php on line 13
abhilash@abhilash:~$

falstro · Accepted Answer · 2010-01-15 14:19:02Z

14

You are returning the variable incorrectly inside the function. It should be:

return $this->contents

edited Jan 15, 2010 at 14:19

falstro

35.9k11 gold badges76 silver badges88 bronze badges

answered Jan 15, 2010 at 14:17

Extrakun

19.3k23 gold badges85 silver badges138 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Lachlan McDonald Over a year ago

What Extrakun means is that you don't include the $ when setting or accessing an object's variables.

Narcissus Over a year ago

There's actually another problem, too... the echo statement requires a dollar sign before the abhilash variable name.

Extrakun Over a year ago

As a further explanation why it is valid syntax, you can store a function name into a variable and invoke it by putting the brackets behind it, which is why PHP complains it as an 'empty property'

VolkerK · Accepted Answer · 2010-01-15 14:37:06Z

5

Since the question is tagged as "php5" here's an example of your class with php5 class notation (i.e. public/protected/private instead of var, public/protected/private function, __construct() instead of classname(), ...)

class abhi {
  protected $contents="default_abhi";

  public function __construct($contents) {
    $this->contents = $contents;
  }

  public function get_whats_there() {
    return $this->contents;
  }
}

$abhilash = new abhi("abhibutu");
echo $abhilash->get_whats_there();

edited Jan 15, 2010 at 14:37

answered Jan 15, 2010 at 14:28

VolkerK

96.3k20 gold badges169 silver badges232 bronze badges

3 Comments

Tom Over a year ago

Is there any reason to re-assign contents in the constructor? I know the original poster did, but is there a value to it?

Felix Kling Over a year ago

@Tom: You can set contents at runtime via $a = new abhi('new content')

VolkerK Over a year ago

@Tom: Not really in this case. But fi another class extends abhi and its constructor doesn't call abhi::__construct() $contents will at least be set to "default_abhi" which might be sufficient in some cases.

Psytronic · Accepted Answer · 2010-01-15 14:18:14Z

4

If i recall correctly it would be

$this->contents = $contents;

not

$this->$contents = $contents;

answered Jan 15, 2010 at 14:18

Psytronic

6,1135 gold badges40 silver badges56 bronze badges

Comments

Simon · Accepted Answer · 2010-01-15 14:18:25Z

3

Should be accessing and writing to $this->contents not $this->$contents

answered Jan 15, 2010 at 14:18

Simon

38k2 gold badges37 silver badges27 bronze badges

Comments

Softnux · Accepted Answer · 2010-01-15 14:24:44Z

1

Also, are you not missing a dollar-sign in "echo abhilash->get_whats_there();"? ($abhilash->..)

answered Jan 15, 2010 at 14:24

Softnux

2,7404 gold badges21 silver badges21 bronze badges

Comments

appusajeev · Accepted Answer · 2010-01-15 14:22:03Z

0

use $this->contents
i too at first had the same problem

answered Jan 15, 2010 at 14:22

appusajeev

2,3194 gold badges23 silver badges20 bronze badges

Comments

Radu M. · Accepted Answer · 2010-01-15 14:28:45Z

0

You have a problem with $: 1. when using $this-> you do not put $ between "->" and the variable name the "$" sign, so your $this->$contents should be $this->contents. 2. in your echo youforgot the $ when calling that function from the instantiated class.

So your correct code is:

<?php
class abhi
{
    var $contents="default_abhi";

    function abhi($contents)
    {
        $this->contents = $contents;
    }

    function get_whats_there()
    {
        return $this->contents;
    }

}

$abhilash = new abhi("abhibutu");
echo $abhilash->get_whats_there();

?>

answered Jan 15, 2010 at 14:28

Radu M.

5,7804 gold badges44 silver badges54 bronze badges

Collectives™ on Stack Overflow

php code is not executing?

7 Answers 7

3 Comments

3 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

7 Answers 7

3 Comments

3 Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related