Creating a multithreaded server using SocketServer framework in python

Question

#!/usr/bin/env python
#-*- coding: utf-8 -*-

import sys
sys.dont_write_bytecode = True
import shlex
import subprocess
import SocketServer

sess = []

class TCPHandler(SocketServer.BaseRequestHandler):
    def handle(self):
        global sess
        sess.append(self.request)
        ip,port = self.client_address
        print "#%d: client %s:%d"%(len(sess),ip,port)
        while True:
            cmd = self.request.recv(8192)
            out = subprocess.check_output(shlex.split(cmd),stderr=subprocess.STDOUT,shell=True)
            self.request.send(out)
        self.request.close()
class ThreadedTCPServer(SocketServer.ThreadingMixIn,SocketServer.TCPServer): pass

if __name__ == "__main__":
    port = 4242
    svr = ThreadedTCPServer(("",port),TCPHandler)
    print ":%d"%port
    svr.serve_forever()

evandrix · Accepted Answer · 2019-12-06 06:57:25Z

8

It is much more simple than you think:

class ThreadedTCPServer(SocketServer.ThreadingMixIn,SocketServer.TCPServer): pass

Than you just have to use your new ThreadedTCPServer instead of TCPServer.

For more information you can read some doc.

However in your code you made some mistakes:

The target argument must be a callable object not an "already-called" object.
To handle many requests you need to build a Threads pool. If you only use one thread it does not make any difference if it is the main thread or a "child" thread.

edited Dec 6, 2019 at 6:57

evandrix

6,2464 gold badges30 silver badges38 bronze badges

answered Dec 23, 2013 at 14:37

smeso

4,31521 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ρss Over a year ago

Well, thanks. The example in docs is complicated for newbie like me. So, I used your idea and now my programme works as intended.

evandrix · Accepted Answer · 2019-12-06 07:18:30Z

1

#!/usr/bin/env python
#-*- coding: utf-8 -*-

import sys
sys.dont_write_bytecode = True
import shlex
import subprocess
import SocketServer

sess = []

class TCPHandler(SocketServer.BaseRequestHandler):
    def handle(self):
        global sess
        sess.append(self.request)
        ip,port = self.client_address
        print "#%d: client %s:%d"%(len(sess),ip,port)
        while True:
            cmd = self.request.recv(8192)
            out = subprocess.check_output(shlex.split(cmd),stderr=subprocess.STDOUT,shell=True)
            self.request.send(out)
        self.request.close()
class ThreadedTCPServer(SocketServer.ThreadingMixIn,SocketServer.TCPServer): pass

if __name__ == "__main__":
    port = 4242
    svr = ThreadedTCPServer(("",port),TCPHandler)
    print ":%d"%port
    svr.serve_forever()

edited Dec 6, 2019 at 7:18

evandrix

6,2464 gold badges30 silver badges38 bronze badges

answered Dec 23, 2013 at 15:26

ρss

5,3139 gold badges45 silver badges75 bronze badges

1 Comment

smeso Over a year ago

This line thread.start_new_thread(server.serve_forever(),()) should simply be server.serve_forever().

Aviram · Accepted Answer · 2013-12-23 14:48:08Z

-2

Shouldn't you loop the

server = SocketServer.TCPServer(('',1520), service)
t = Thread(target=server.serve_forever())
t.start()

Just a guess..

answered Dec 23, 2013 at 14:48

Aviram

142 bronze badges

Collectives™ on Stack Overflow

Creating a multithreaded server using SocketServer framework in python

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related