MySQL UPDATE query - dealing with empty inputs

Question

This is my first UPDATE query, I have checked using jQuery for any empty fields. I want the user to input at least one field and then update the field(s). Doing a query with all the $_POST names might generate empty or undefined input fields in my database which doesn't work.. here is my query:

$first = $_POST['first'];
$last = $_POST['last'];
$birth = $_POST['birth'];
$bio = $_POST['bio'];

$UID = $_SESSION['id'];

$query = "UPDATE `user` SET `firstname`=$first,`lastname`=$last,`birthday`=$birth,`biography`=$bio WHERE `user_id` = '$UID'";
$result = mysql_query($query) or die($result . "<br/><br/>" . mysql_error());

The error: syntax to use near 'birthday=,biography= WHERE user_id = '11'' at line 1

I don't want to go through nested if's to check whether has a value or not. Thanks.

Please use prepared statements to avoid SQL injections.

juergen d
– juergen d

2013-12-26 09:26:41 +00:00
Commented Dec 26, 2013 at 9:26 — juergen d
– juergen d, Commented Dec 26, 2013 at 9:26

jogesh_pi · Accepted Answer · 2013-12-26 09:38:51Z

1

NOTE: Use mysql_real_escape_string() to prevent from sql injection.

if( !empty($first) && 
    !empty($last) && 
    !empty($birth) && 
    !empty($bio) ){

$query = "UPDATE `user` 
             SET 
               `firstname`='$first',
               `lastname`='$last',
               `birthday`='$birth', 
               `biography`='$bio' 
           WHERE `user_id` = '$UID'";
}

edited Dec 26, 2013 at 9:38

answered Dec 26, 2013 at 9:27

jogesh_pi

9,7745 gold badges40 silver badges65 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Atieh Over a year ago

ok this is working, but they are updating the empty fields, so I have to check for this one?

jogesh_pi Over a year ago

@Atieh yes you have to check empty fields before update, otherwise it update empty value on every refresh, check the updated answer.

Atieh Over a year ago

I got the idea, but this isn't my case, if it's empty I will set it to the current value..thanks!

Collectives™ on Stack Overflow

MySQL UPDATE query - dealing with empty inputs

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related