Object as default argument value in class method

Question

Now I have this:

abstract class PermissionModelAbstract implements PermissionModelInterface
{
    public function setDataValidator(string $action, string $method, DataPermissionValidatorInterface $validator = null)
    {
        if (is_null($validator)) {
            $validator = new DefaultDataValidator();
        }
        $this->model[$action . '/' . $method]['validator'] = $validator;
    }
}

I want to have something like:

abstract class PermissionModelAbstract implements PermissionModelInterface
{
    public function setDataValidator(string $action, string $method, DataPermissionValidatorInterface $validator = new DefaultDataValidator())
    {
        $this->model[$action . '/' . $method]['validator'] = $validator;
    }
}

Is there exists some way to do it?

@onetrickpony , no, it isn't. You cannot construct new instances as default parameters. Try learning PHP. tnxbye — tereško
– tereško, Commented Dec 27, 2013 at 19:46
I was referring to the first code snippet. And I'm curious why OP is seeking a different way — nice ass
– nice ass, Commented Dec 27, 2013 at 19:49

lafor · Accepted Answer · 2013-12-27 19:49:50Z

1

I'd get rid of calling new inside the method altogether. It introduces tight coupling plus the expectation that a setFoo() setter would be called without the actual foo is bizarre.

Keep the type check in the signature:

public function setDataValidator(string $action, string $method, DataPermissionValidatorInterface $validator);

Then simply provide the dependency "manually" when calling the method:

myPermissionModel->setDataValidator('foo', 'bar', new DataPermissonValidator());

answered Dec 27, 2013 at 19:49

lafor

12.8k4 gold badges34 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Madara's Ghost · Accepted Answer · 2013-12-27 19:52:52Z

0

No other way of doing it, AFAIK.

If you have many dependencies to the point it gets cumbersome to maintain, consider using a Dependency Injection Container.

answered Dec 27, 2013 at 19:52

Madara's Ghost

176k52 gold badges274 silver badges314 bronze badges

Collectives™ on Stack Overflow

Object as default argument value in class method

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related