Can't prevent form to submit when javascript validation fails

Question

I am learning Javascript and this might be a very stupid question but I am running nuts. I was trying all sort of things to prevent a form to be submitted with no luck so now I placed a very simple function that will always return false. Still the form is submitted, can someone explain why and what do I need to change? THANKS!

<form action="http://students.open.ac.uk/mct/tt284/reflect/reflect.php" method="post" name="displayTimeTable" onsubmit="return toSubmit();">

<some html>.....

<input type="submit" id="submit" name="submit" value="Submit" />

`

and the javascript

function toSubmit(){
  alert('I will not submit');
  return false;

}

Just use Javascript to improve visitors experience. They might turn it off. So you need to also do validation at the server end. — Ed Heal
– Ed Heal, Commented Dec 29, 2013 at 15:00
I am using Fiddle since the beginning. The HTML tags are properly closed. — Joy Adamson
– Joy Adamson, Commented Dec 29, 2013 at 15:00

iMx · Accepted Answer · 2013-12-29 14:57:13Z

1

Try an onclick event on the submit button instead of onSubmit

<input type="submit" id="submit" name="submit" value="Submit" onclick="return toSubmit();"/>

answered Dec 29, 2013 at 14:57

iMx

8461 gold badge9 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

oznu Over a year ago

Change the type to 'button'.

iMx Over a year ago

@JoyAdamson can you create a fiddle at jsfiddle.net? A button can't submit the form by itself, it have to call the submit function. But in your case it must work with the submit button too.

Prasanth K C Over a year ago

@JoyAdamson i think there is the problem.. you are checking it in fiddle only rite?? in fiddle such script should be put in same frame where html is written, like this FIDDLE >>

iMx Over a year ago

@JoyAdamson see your fiddle now... The function will not work in the script frame. If moved it in the HTML block, it works now.

user447356 Over a year ago

@JoyAdamson your fiddle didn't work because by default the scope is "onLoad" meaning whatever functions you write, they are local to the window onload event and can't be called from within buttons. See this updated fiddle where same code works after choosing "No wrap" option.

|

Sergei Zahharenko · Accepted Answer · 2013-12-29 15:28:29Z

0

Working fine for me:

http://jsfiddle.net/acrashik/yQ2gL/1/

<script>
    var onSubmit = function() {
        return false;
    }
</script>
<form action="/" method="post" onsubmit="return onSubmit();">
<input type="submit" />
</form>

answered Dec 29, 2013 at 15:28

Sergei Zahharenko

1,52412 silver badges16 bronze badges

Collectives™ on Stack Overflow

Can't prevent form to submit when javascript validation fails

2 Answers 2

10 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related