Problems adding data into a datatable C#

Question

I am working on a school project that includes data-bases. I got the basiscs of SQL programming but I still getting problems. Now I'm stuck on the code that is supposed to add new data into the grid, but it's just not working for some reason.. I tried to find a solution for this problem (as you can see from the code), but nothing worked.. Here is the code.

private void InsertData()
    {
        string NewCode = GenerateCode();
        string NewLetter = txtNewData.Text;

        try
        {
            Connection.Open();
            string AddData = "INSERT INTO DictionaryTest (BinNumber,Letter) VALUE (@NewCode,@NewLetter)";
            //SqlDataAdapter DataIns = new SqlDataAdapter(AddData, Connection);
            SqlCommand DataAdd = new SqlCommand(AddData, Connection);
            DataAdd.Parameters.AddWithValue("@NewCode", "00" + NewCode);
            DataAdd.Parameters.AddWithValue("@NewLetter", NewLetter);
            //DataAdd.ExecuteNonQuery();
            //Connection.Open();
            //var dt = new DataTable();
            //DataIns.Fill(dt);
            Connection.Close();
        }
        catch (Exception e)
        {
            Console.WriteLine(e.ToString());
        }
    }

The data that I'm getting from the fucntion GenerateCode() is ok, I tried to insert it into a text box and it was right.

You've commented out the code that executes the query, and you need to open the connection before you do. Put your open connection code above your execute query code, and uncomment both :) — JMK
– JMK, Commented Dec 29, 2013 at 18:30
No problem, obviously I totally missed the pluralization on Values which AkbarRezaee pointed out, which I'm guessing you worked out. — JMK
– JMK, Commented Dec 29, 2013 at 18:50

Ross Dargan · Accepted Answer · 2013-12-29 18:38:36Z

2

You need to execute the sqlcommand

try adding this before the close

DataAdd.ExecuteNonQuery();

But beware SqlConnection, and SqlCommand both implement IDisposable, so you should be calling .Dispose on them (or more preferably using a using statement).

This tends to be how I write sql queries:

using(SqlConnection connection = new SqlConnection("connection string"))
{
    using(SqlCommand command = new SqlCommand("command",connection);
    {
        //Add params as in your example
        connection.Open();
        command.ExecuteNonQuery(); // Or Execute reader to get results back
        connection.close(); //The using statement will close dispose, which will close the connection so this isn't strictly required.
    }
}

Hope that helps.

answered Dec 29, 2013 at 18:38

Ross Dargan

6,0315 gold badges42 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

user3144416 Over a year ago

Umm how exactly am I using this .Dispose option?

JMK Over a year ago

@user3144416 There's a good reference on MSDN here

Ross Dargan Over a year ago

Here is another good place to start

Manian Rezaee · Accepted Answer · 2013-12-29 18:36:29Z

1

change value to values

INSERT INTO DictionaryTest (BinNumber,Letter) VALUES (@NewCode,@NewLetter)

answered Dec 29, 2013 at 18:36

Manian Rezaee

1,02212 silver badges26 bronze badges

Collectives™ on Stack Overflow

Problems adding data into a datatable C#

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related