Create word count of text using hashmap

Question

I am trying to create a program as a tutorial for myself for hashmaps. I ask the user into text and try to split it into hashmaps and then increase the count if the word repeats. This is my program:

import java.util.*;
import java.lang.*;
import javax.swing.JOptionPane;
import java.io.*;
public class TestingTables
{
   public static void main(String args[])
   {
      {
      String s = JOptionPane.showInputDialog("Enter any text.");
      String[] splitted = s.split(" ");
      HashMap hm = new HashMap();
      int x;

      for (int i=0; i<splitted.length ; i++) {
         hm.put(splitted[i], i);
         System.out.println(splitted[i] + " " + i);
         if (hm.containsKey(splitted[i])) {
             x = ((Integer)hm.get(splitted[i])).intValue();
             hm.put(splitted[i], new Integer(x+1)); }
         }
      }
   }
}

When I input "random random random", I get: random 0 random 1 random 2

What do I need to change so I get: random 3 Also, do I need to use an iterator to print out the hashmap, or is what I used OK?

@MiserableVariable I found the syntax on the Java API and it was the variable that they were using in the example. I just forgot to change it. — f3d0r
– f3d0r, Commented Dec 31, 2013 at 1:14

peter.petrov · Accepted Answer · 2013-12-30 23:58:50Z

5

Your initialization is wrong hm.put(splitted[i], i). You should initialize to 0 or to 1 (to count, not to index).

So do this loop first.

        for (int i = 0; i < splitted.length; i++) {
            if (!hm.containsKey(splitted[i])) {
                hm.put(splitted[i], 1);
            } else {
                hm.put(splitted[i], (Integer) hm.get(splitted[i]) + 1);
            }
        }

Then just do one more loop (iterate through the keys of the HashMap) and print the counts out.

        for (Object word : hm.keySet()){
            System.out.println(word + " " + (Integer) hm.get(word));
        }

answered Dec 30, 2013 at 23:58

peter.petrov

39.6k23 gold badges114 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Vannens · Accepted Answer · 2013-12-31 00:03:18Z

0

import java.util.*;
import java.lang.*;
import javax.swing.JOptionPane;
import java.io.*;
public class TestingTables
{
   public static void main(String args[])
   {
      {
      String s = JOptionPane.showInputDialog("Enter any text.");
      String[] splitted = s.split(" ");
      Map<String, Integer> hm = new HashMap<String, Integer>();
      int x;

      for (int i=0; i<splitted.length ; i++) {
         if (hm.containsKey(splitter[i])) {
            int cont = hm.get(splitter[i]);
            hm.put(splitter[i], cont + 1)
         } else {
            hm.put(splitted[i], 1);
         }
      }
   }
}

Your Map declaration is wrong, remember the correct way to implement a Map.

answered Dec 31, 2013 at 0:03

Vannens

1671 silver badge10 bronze badges

3 Comments

peter.petrov Over a year ago

His map declaration is not wrong, he just does not use generics (which is not recommended but is not wrong too).

Vannens Over a year ago

@peter.petrov Oh okay, I've never seen that declaration before.

IS_EV Over a year ago

@Vannens I believe this came up with java 5 release.

IS_EV · Accepted Answer · 2013-12-31 00:10:13Z

0

This should work, its a pretty simple implementation..

        Map<String, Integer> hm = new HashMap<String, Integer>();
    int x;

    for (int i = 0; i < splitted.length; i++) {

        if (hm.containsKey(splitted[i])) {
            x = hm.get(splitted[i]);
            hm.put(splitted[i], x + 1);
        } else {
            hm.put(splitted[i], 1);
        }
    }

    for (String key : hm.keySet()) {

        System.out.println(key + " " + hm.get(key));
    }

answered Dec 31, 2013 at 0:10

IS_EV

1,0483 gold badges16 silver badges32 bronze badges

Collectives™ on Stack Overflow

Create word count of text using hashmap

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related