Setting JS variable to PHP variable error

Question

I want to use a php login name in my javascript game...

I have this at the top of my php page that runs the javascript:

<?php
$username = (isset($_GET['username']) ? ($_GET['username']) : "dude");
?>

In my javascript I have this... which doesn't alert the name at all and throws a Uncaught ReferenceError: daniel is not defined error:

var name = <?php echo $username; ?>;
alert(name);

And then I have this... which displays the name correctly at the top of the HTML:

<?php  
  echo "Welcome back " . $username . "...";
?>

If the name is being displayed correctly server side when the page has loaded, why can't it be alerted out from the Javascript?

Thanks

Zarathuztra · Accepted Answer · 2014-01-02 03:34:22Z

2

You aren't delimiting the value as a JavaScript string. It may be a string on the server, but not on the client. Do the following:

Change this:

var name = <?php echo $username; ?>;

To this:

var name = "<?php echo $username; ?>";

answered Jan 2, 2014 at 3:34

Zarathuztra

3,2411 gold badge23 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

No worries dude, happens to all of us. ;)

Mahmood Rehman · Accepted Answer · 2014-01-02 03:34:24Z

1

Enclose your php code within quotes.Try like this :

<script type="text/javascript">
    var name = '<?php echo $username; ?>';
    alert(name);  
</script>

answered Jan 2, 2014 at 3:34

Mahmood Rehman

4,3377 gold badges43 silver badges76 bronze badges