Iterating through array angular

Question

I am following a todo list angular tutorial. Right now, I would like to loop through all of my todo list and clear all of the items where the attribute done is true.

Right now in my index.html file I have a button with the ng-click attribute of "clearCompleted()". That function looks like this in my js file:

$scope.clearCompleted = function () {
  $scope.todos = $filter($scope.todos, function(todo){
    return !todo.done;
  });
};

What is wrong with this function because it is not clearing the todo items that are being set to done:true.

And in more of a general question, what is the typical way I could say something along the lines of "select all the items where the attribute done is true" because I am more used to ruby and not javascript.

I understand that, clearly something in this function is not letting me filter properly. — user2184718
– user2184718, Commented Jan 2, 2014 at 17:12
Ahh - I misread your code. No, that does appear to be the right idea. Sorry, if I were an Angular guy I could likely help. — Adam Rackis
– Adam Rackis, Commented Jan 2, 2014 at 17:14
Why use $filter at all? Seems like just using Array.filter (or equivalent helper with jQuery or underscore) would be simpler and probably faster. — Marplesoft
– Marplesoft, Commented Jan 2, 2014 at 21:30

a better oliver · Accepted Answer · 2014-01-02 17:31:47Z

2

$filter(name)gets the filter with that name. In order to actually call it you can write `$filter(name)(/arguments for the filter/)

There is a predefined filter called filter that can be used for filtering arrays. You pass in an object for comparisons:

$scope.clearCompleted = function () {
    $scope.todos = $filter("filter")($scope.todos, {done:false});
};

Which returns all items that have the property donewith the value false.

answered Jan 2, 2014 at 17:31

a better oliver

26.9k2 gold badges64 silver badges67 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ivan Chernykh · Accepted Answer · 2014-01-02 17:34:24Z

1

Try this syntax:

$scope.todos = $filter("filter")($scope.todos, function(todo){

Example: http://jsfiddle.net/cherniv/89Qqs/

And don't forget to inject the $filter service into controller first!

edited Jan 2, 2014 at 17:34

answered Jan 2, 2014 at 17:20

Ivan Chernykh

42.2k13 gold badges136 silver badges148 bronze badges

Collectives™ on Stack Overflow

Iterating through array angular

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related