Javascript test() method syntax error?

Question

I'm attempting to convert (what I've found to be) the best email validation function (located here: http://www.linuxjournal.com/article/9585?page=0,3) from php to javascript. Regardless of the fact that "you shouldn't validate with javascript because javascript can be disabled". Obviously I can't leave in the checkdnsrr() portion of the function, but everything else should be doable with javascript.

So far the function works as expected up until this line:else if(/\.\./.test(domain)) {

I know it's pretty useless without context, so the full function is below. What's also weird is that it gives a "pass" to a line with the exact same regex pattern:else if(/\.\./.test(local)) { which is used a few lines before it. Strange.

function validEmail(email) {
    var isValid = true;
    var atIndex = email.indexOf("@");
    var ending = email.length - 1;
    if(typeof(atIndex) == "boolean" && !atIndex) {
         isValid = false;
    }
    else {
        var domain = email.substr(atIndex+1);
        var local = email.substr(0, atIndex);
        var localLen = local.length;
        var domainLen = domain.length;
        if(localLen < 1 || localLen > 64) {
            // local part length exceeded
            isValid = false;
        }
        else if(domainLen < 1 || domainLen > 255) {
            // domain part length exceeded
            isValid = false;
        }
        else if(local[0] == '.' || local[localLen-1] == '.') {
            // local part starts or ends with '.'
            isValid = false;
        }
        else if(/\.\./.test(local)) {
            // local part has two consecutive dots
            isValid = false;
        }
        else if(/^[A-Za-z0-9\\-\\.]+$/.test(domain) == false)
            // character not valid in domain part
            isValid = false;
        }
        else if(/\.\./.test(domain)) {
            // domain part has two consecutive dots
            isValid = false;
        }
        else if(/^(\\\\.|[A-Za-z0-9!#%&`_=\/$'*+?^{}|~.-])+$/.test(local.replace("\\\\",""))) {
            // character not valid in local part unless
            // local part is quoted
            if(/^"(\\\\"|[^"])+"$/.test(local.replace("\\\\",""))) {
                isValid = false;
            }
        }
    }
    return isValid;
}

Ah, yea sorry... That's actually not in the function I'm testing. I had a string there instead which would indicate which portion of the conditionals failed. Forgot to remove the quotes. — Amygdala
– Amygdala, Commented Jan 7, 2014 at 4:20

SLaks · Accepted Answer · 2014-01-07 04:20:16Z

1

You missed a { in the previous if.

Therefore, that else has no if connected to it.

answered Jan 7, 2014 at 4:20

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Javascript test() method syntax error?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related