JavaScript simple parameter error

Question

function moveDoi(n) {
        var delay = -1;
        var left = document.getElementById("One");         
        var currentLeft = parseInt(getComputedStyle(left).left, 10);
        setTimeout(move, delay);
        function move(){
          if (currentLeft <= n ) {            
            currentLeft+=3;            
            left.style.left = currentLeft + "px";            
            setTimeout(move, delay);       
          }
        }
      };

In this code I have n as a parameter of the function, that is used in the if conditional statement. For this function i need to have one more parameter x that will change the "One" so i need to obtain something like this: document.getElementById(""+x+"") . However, this is not working?

How can I add one more parameter to the function that needs to be in quotes (" ") in function?

since your x will be a string, you need not put it inside another set of quotes. Simply use document.getElementbyId(x). — Yogesh
– Yogesh, Commented Jan 8, 2014 at 15:49

Patrick Q · Accepted Answer · 2014-01-08 15:55:05Z

1

First, you need to pass x into the function. Then, you simply need to reference it when calling document.getElementById. There are is no need to append/prepend quotes, since x is already a string.

function moveDoi(n, x) {
        var delay = -1;
        var left = document.getElementById(x);         
        var currentLeft = parseInt(getComputedStyle(left).left, 10);
        setTimeout(move, delay);
        function move(){
          if (currentLeft <= n ) {            
            currentLeft+=3;            
            left.style.left = currentLeft + "px";            
            setTimeout(move, delay);       
          }
        }
      };

edited Jan 8, 2014 at 15:55

answered Jan 8, 2014 at 15:46

Patrick Q

6,3942 gold badges28 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Yogesh Over a year ago

Can you add comments to explain what the OP was doing wrong, what should he have done instead?

Yogesh Over a year ago

much better. Adding comments helps them not make the same mistake again.

Collectives™ on Stack Overflow

JavaScript simple parameter error

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related