cannot modify array value?

Question

I have a simple php script that handles form data. In the form I have several checkboxes, and when those are checked, the form contains "on" as a value.

For the remainder of the script, I need to have the string "1" instead of "on", but I can't change it for some reason.

Here is the script:

$posted=$_POST;
foreach ($posted as $key=>$val) {
    if ($val == "on") {
        $posted[$key] = "1";
    }
}
// The $_POST parameters
echo 'The $_POST parameters:';
echo '<pre>';
var_dump($_POST);
echo '</pre>';

// The $posted parameters after conversion
echo 'The $posted parameters (after \'conversion\'):';
echo '<pre>';
var_dump($posted);
echo '</pre>';

And the output:

The $_POST parameters:
array(3) {
  ["id"]=>
  string(6) "142892"
  ["help"]=>
  string(2) "on"
  ["vm"]=>
  string(2) "on"
}

The $posted parameters (after 'conversion'):

array(3) {
  ["id"]=>
  string(6) "142892"
  ["help"]=>
  string(2) "on"
  ["vm"]=>
  string(2) "on"
}

but he is already modifying $posted variable not the $_POST variable itself. — rccoros
– rccoros, Commented Jan 10, 2014 at 11:02
@MurtazaHussain I beg to differ, given that I use $_POST = json_decode(file_get_contents("php://input"),true); all the time. — Niet the Dark Absol
– Niet the Dark Absol, Commented Jan 10, 2014 at 11:03

Ryan Vincent · Accepted Answer · 2014-01-11 10:31:01Z

3

First the code you supplied does what you expect and modifies the 'posted' array correctly (PHP 5.3.18).

According to the PHP 'foreach' documentation, to modify the 'value' in the loop you need to use a 'reference' to the 'value' as follows:

As you are only interested in modifying all the 'on' values in the posted' array then the following code does that and is clear as to what is being changed.

$posted=$_POST;
foreach ($posted as &$val) { // note the 'reference' on $val
    if ($val == "on") {
        $val = "1";
    }
}

This does what you want without any extra variables.

answered Jan 11, 2014 at 10:31

Ryan Vincent

4,5137 gold badges24 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Afroz Alam · Accepted Answer · 2014-01-10 11:40:01Z

0

Here it is:

 $posted = array();
    $posted=$_POST;
    foreach ($posted as $key=>$val) {
        if ($val == "on") {
            $_POST[$key] = "1";
        }
    }
    var_dump($_POST);

answered Jan 10, 2014 at 11:40

Afroz Alam

8746 silver badges19 bronze badges

Comments

Ruben Giaquinto · Accepted Answer · 2014-01-10 12:59:30Z

0

You should use another array when you use a foreach loop

$posted = array();
$postArray = $_POST;
foreach ($postArray as $key=>$val) {
    if ($val == "on") {
        $posted[$key] = "1";
    }
    else {
        $posted[$key] = $val;
    }
}
var_dump($posted);

An array used in a foreach loop is not editable and it doesn't work.

answered Jan 10, 2014 at 12:59

Ruben Giaquinto

3901 silver badge14 bronze badges

Comments

Brightshine · Accepted Answer · 2014-01-10 11:33:46Z

-1

It should be:

$posted = array();
$posted=$_POST;
foreach ($posted as $key=>$val) {
    if ($val == "on") {
        $posted[$key] = "1";
    }
}

answered Jan 10, 2014 at 11:33

Brightshine

9651 gold badge7 silver badges17 bronze badges

1 Comment

Afroz Alam Over a year ago

It is the same code that is used by koljanep in his question.

Collectives™ on Stack Overflow

cannot modify array value?

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related