In my current project (OpenGL Voxel Engine) I have a serious issue when generating models. I have a very object oriented structure, meaning that even single parameters of my vertices are Objects. This way I am creating about 75000 Objects for 750 voxels in about 5 seconds. Is Java really this slow when allocating new Objects or do I miss a big failure somewhere in my code?
-
It varies among the type of Object(s).Elliott Frisch– Elliott Frisch2014-01-10 22:01:43 +00:00Commented Jan 10, 2014 at 22:01
-
because you are using the object type?esmoreno– esmoreno2014-01-10 22:02:45 +00:00Commented Jan 10, 2014 at 22:02
-
A good JVM is probably faster overall at creating objects than a C++ system. It's just that there are so many objects used in Java (especially when the app is poorly designed).Hot Licks– Hot Licks2014-01-10 22:03:10 +00:00Commented Jan 10, 2014 at 22:03
-
It also depends on how long the objects might live, if you're creating a bunch of short lived objects, the GC might kick in, reducing the performance. I've implemented Object pooling before, win allowed to go from 500 moving object so to 4500 all using basic Swing graphics...MadProgrammer– MadProgrammer2014-01-10 22:04:19 +00:00Commented Jan 10, 2014 at 22:04
-
3OK i just localized that I am retesselating my VBOs for every Vertex I am adding. Problem solved.th3falc0n– th3falc0n2014-01-10 22:14:50 +00:00Commented Jan 10, 2014 at 22:14
|
Show 5 more comments
6 Answers
Very big question. Generally speaking, it depends from the object class definition and by the amount of work required to construct object.
Some issue:
- avoid finalize method,
- tune memory and GC in order to avoid excessive GC activity,
- avoid big work during constructor,
- do not use syncronization call during object construction,
- use Weak references
these issues solved my problem.
See also http://oreilly.com/catalog/javapt/chapter/ch04.html
Finally let me suggest you the (deprecated) Object Pool pattern or reuse objects.
Concluding, no, generally speaking, java object creation is not slow
3 Comments
ThanksForAllTheFish
In this particular, I believe the problem is point 3: lot of work during construction. I would just change the last sentence in
generally speaking, Java is really fast in creating object. I found some benchmarks few months ago to prove this, I should look for them again
venergiac
@Mardavi if you can retrieve the benchmarks it is very interesting
ThanksForAllTheFish
to start: onlinevillage.blogspot.ch/2011/03/… on a side note, this is also interesting (does not show result, but it goes deep into java performance monitoring): ibm.com/developerworks/library/j-5things8
Of course it isn't. The following code allocates 10 million objects and stores them in an array. On my 5 year old notebook, it completes in 1.4 seconds.
public class Test {
public static void main(String[] args) {
Object[] o = new Object[10_000_000];
long start = System.nanoTime();
for (int i = 0; i < o.length; i++) {
o[i] = new Object();
}
long end = System.nanoTime();
System.out.println(Arrays.hashCode(o));
System.out.println(new BigDecimal(end - start).movePointLeft(9));
}
}
... and that's even though this benchmark is quite naive in that it doesn't trigger just in time compilation of the code under test before starting the timer.
1 Comment
Antonio
new is fast; here new was fast possibly because garbage collector did not pause the loop, otherwise the code may experience performance penaltiesSimply creating 75,000 objects should not take 5 seconds. Take a look at the work your constructor is doing. What else are you doing during this time besides creating the objects? Have you tried timing the code to pinpoint where delays occur?
1 Comment
th3falc0n
As I said in question commands I found the mistake in my engine.
Objects will be slower than primitives, and they will also consume considerably more memory - so it's possible you are going overboard on them. It's hard to say without seeing more details.
75000 objects will not take a long time to create though, try this:
List<Integer> numbers = new ArrayList<Integer>();
for(int i = 0;i<75000;i++){
numbers.add(i); // Note this will autobox creating an Integer object after the first 128
}
System.out.println(numbers.size());
}
http://www.tryjava8.com/app/snippets/52d070b1e4b004716da5cb4f
Total time taken less than a second.
When I put the number up to 7,500,000 it finally took a second...
1 Comment
th3falc0n
Thanks for the interesting website, but I think I just crashed the servers o.O
The new operator in java is very fast compared to the common approach in languages without automatic memory management (e.g. the new operator is usually faster than the malloc-command in C because it does not need a system call).
Although the new operator can still be a bottleneck, it is certainly not the problem in your case. Creating 75K objects should be WAY faster than 5 seconds.
Comments
I have the same issue with creating new objects.
My object in constructor allocate single three dimensional array 64x64x64 and no more. FPS fell down to quarter of a value.
I solve this issue with reusing old object and reset it's state (BTW this method reallocate this array without lost performance).
If I move allocation array into separate method and call it after creating the object, speed does not increase to acceptable value.
This object I created is in Main game loop.
