String Causing Unexpected Errors

Question

I'm having a problem with some code, in the constructor of the level, i have this.public

Level(int width, int height, String level) {
    grid=new Block[width][height];
    String v = "";
    for (int y = 0; y < height; y++) {
        for (int x = 0; x < width; x++) {
            char s = level.charAt(y * height + x);
            if (s=='#') {
                grid[x][y] = new Wall(x, y);
            } else if (s=='_'){
                grid[x][y] = new Block(x, y);
            }
        }
    }
}

Only when I run the Level initializer with the following...

              new Level(16,16,"###############" +
                              "#_____________#" +
                              "#___######____#" +
                              "#___#____###__#" +
                              "#___#__###_#__#" +
                              "#####_________#" +
                              "#_____#__######" +
                              "#___###_______#" +
                              "#_#_#_# #####_#" +
                              "#_#___#____#__#" +
                              "#_#####__###_##" +
                              "#_____####____#" +
                              "#_#_#______##_#" +
                              "###_#__#####__#" +
                              "#___#______#__#" +
                              "###############");

I get

    Exception in thread "main" java.lang.StringIndexOutOfBoundsException: 
    String Index out of range: 240
at java.lang.String.charAt(String.java:686)
at Level.<init>(Level.java:17)
at Game.<init>(Game.java:12)
at Main.main(Main.java:7)`

Any help is greatly appreciated.

Mitesh Pathak · Accepted Answer · 2014-01-11 07:37:24Z

4

Your grid is 16 * 15 (and hence the exception while calculating char position)

[EDIT] modify you formula

char s = level.charAt(y * width + x);

edited Jan 11, 2014 at 7:37

answered Jan 11, 2014 at 7:32

Mitesh Pathak

1,21110 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Barakados Over a year ago

Ah my bad. Thanks so much for catching that.

Mitesh Pathak Over a year ago

yep also to be on safer side I will always pass height as first arg and then width to my func....

Guntram Blohm · Accepted Answer · 2014-01-11 07:34:38Z

1

Also,

char s = level.charAt(y * height + x);

should probably be

char s = level.charAt(y * width + x);

answered Jan 11, 2014 at 7:34

Guntram Blohm

9,8492 gold badges27 silver badges36 bronze badges

Collectives™ on Stack Overflow

String Causing Unexpected Errors

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related