Update ListView row items on click of button

Question

I have a ListView with some TextViews, an ImageView & a Button. the ImageView is bydefault 'Invisible'. In button's click handler, I have to do some http calls which can not be done in the UI-Thread, so I have created a background thread for it. Based on the result of the http call, I have to show the ImageView (which was initially 'Invisible').

Here is a part of my layout file (list_row.xml):

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="fill_parent"
    android:layout_height="wrap_content"
    android:background="@drawable/list_selector"
    android:padding="5dip" >

<ImageView
    android:id="@+id/imageViewIcon"
    android:layout_width="50dip"
    android:layout_height="50dip"
    android:visibility="invisible"
 />

<TextView
    android:id="@+id/textViewName"
    ...
/>

<Button
    android:id="@+id/button"
    ...
/>

Here is how I am setting the adapter:

ListView appList = (ListView) findViewById(R.id.list);
MyAdapter adapter = new MyAdapter(getApplicationContext(), MainActivity.this, MyDataInAnArray);
appList.setAdapter(adapter);

and here is the MyAdapter class:

public class MyAdapter extends BaseAdapter
{
    Context mContext;
    Context mActivity;
    SomeDataType[] mData;
    LayoutInflater mInflater;

public MyAdapter(Context context, Context activity, SomeDatatype[] data)
{
    mContext = context;
    mActivity = activity;
    mData = data;
    mInflater = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
}

    ..... Some more required @Override functions here ....

    @Override
public View getView(final int pos, View convertView, ViewGroup parent)
{
    View vi = convertView;

    if (convertView == null)
        vi = mInflater.inflate(R.layout.list_row, null);

    TextView tvName = (TextView) vi.findViewById(R.id.textViewName);
    tvName.setText(mData[pos].name);

    final ImageView icon = (ImageView) vi.findViewById(R.id.imageViewIcon);

    final Button button = (Button) vi.findViewById(R.id.button);

    button.setOnClickListener(new OnClickListener()
    {
        @Override
        public void onClick(View v)
        {
            Thread thread = new Thread(new Runnable()
            {
                @Override
                public void run()
                {
                    String result = Utils.httpPost("MyURLHere", SomePostData);
                    if (result != null)
                    {
                        ... and some more processing

                        **makeIconVisibile(icon);**
                    }
                }
            });
            thread.start();
        }
    });

    return vi;
}

Question: How should I toggle the visiblity of ImageView in the function makeIconVisible()? Since the http response processing is in a background thread, I can not modify the visiblity directly from there. I will have to run this on UIThread. both mContext.runOnUiThread & mActivity.runOnUiThread are not working. How should I modify the below function to make it work?

private void makeIconVisible(ImageView icon)
{
    // What else is to be done here?
    icon.setVisibility(View.VISIBLE);
}

why are you not using AsynckTask ? Call makeIconVisible in your postExecute mehod of AsynckTask or check out the Volley Library here for faster and cache enable request/response developers.google.com/events/io/sessions/325304728 — Piyush Agarwal
– Piyush Agarwal, Commented Jan 11, 2014 at 12:05
Just save your listview as variable and when the asynk process completed (Enter to onpostexecute()) then refresh the listview — Amsheer
– Amsheer, Commented Jan 11, 2014 at 12:32

sujoy · Accepted Answer · 2014-01-11 13:13:38Z

2

You can try something similar to this, using AsyncTask.

private void makeIconVisible(ImageView icon)
{
    new MakeIconVisibleTask().execute(icon);
}

class MakeIconVisibleTask extends AsyncTask<View, Void, Integer> {
    private View mView;
    String mResult = null;

    @Override
    protected Integer doInBackground(View... arg0) {
        mView = arg0[0];

        mResult = Utils.httpPost("MyURLHere", SomePostData);

        int success = -1; 
        if(mResult!=null && !mResult.isEmpty()) {
            success = 1;
        }

        return success;
    }

    @Override
    protected void onPostExecute(Integer res) {
        if(res >0 ) {
            mView.setVisibility(View.VISIBLE);
        }
    }

}

answered Jan 11, 2014 at 13:13

sujoy

1352 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Vikram.exe Over a year ago

Thank you. That worked with slight modification for my code flow.

Piyush · Accepted Answer · 2014-01-11 13:03:16Z

1

Use this one.

Thread thread = new Thread(new Runnable()
        {
            @Override
            public void run()
            {
                String result = Utils.httpPost("MyURLHere", SomePostData);
                if (result != null)
                {
                    handler.sendEmptyMessage(0);
                }
            }
        });
        thread.start();



Handler handler = new Handler() { 
@Override 
public void handleMessage(Message msg) { 
    makeIconVisibile(icon);
}

};

answered Jan 11, 2014 at 13:03

Piyush

18.9k5 gold badges35 silver badges64 bronze badges

Collectives™ on Stack Overflow

Update ListView row items on click of button

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related