Mutlidimensional array not sorting with PHP usort correctly

Question

I can't get this. Why doesn' this work?

    $list = array(array('id' => 123), array('id' => 10), array('id' => 1000));
    $this->OrderListById($list);
    return $list;

    public function OrderListById($list){
        usort($list, function($a, $b) {return $a['id'] - $b['id'];});
    }

This returns

array(
    (int) 0 => array(
        'id' => (int) 123
    ),
    (int) 1 => array(
        'id' => (int) 10
    ),
    (int) 2 => array(
        'id' => (int) 1000
    )
)

And i was hoping something like more ordered :D

array(
    (int) 0 => array(
        'id' => (int) 10
    ),
    (int) 1 => array(
        'id' => (int) 123
    ),
    (int) 2 => array(
        'id' => (int) 1000
    )
)

possible duplicate of Sort Multi-dimensional Array by Value

Mr. Alien
– Mr. Alien

2014-01-13 14:52:19 +00:00
Commented Jan 13, 2014 at 14:52 — Mr. Alien
– Mr. Alien, Commented Jan 13, 2014 at 14:52

Andris · Accepted Answer · 2014-01-13 14:53:05Z

4

The $list parameter in the OrderListById must be a reference:

public function OrderListById(array &$list)
{
    usort($list, function($a, $b) {
        return $a['id'] - $b['id'];
    });
}

Should work.

As a precaution you could typecast values as you compare them, just in case they are not integers, however, that's something you should check before you sort the array:

return (int) $a['id'] - (int) $b['id'];

answered Jan 13, 2014 at 14:53

Andris

6,1233 gold badges30 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Andris Over a year ago

Ha! It's always something simple, isn't it. Glad to help!

Jessica · Accepted Answer · 2014-01-13 14:53:35Z

4

return $a['id'] - $b['id'];

1000-123 is more than 123-10.

This should be more like the example, where you do a comparison, not subtraction.

function cmp($a, $b)
{
    if ($a == $b) {
        return 0;
    }
    return ($a < $b) ? -1 : 1;
}

In one line that would be:

usort($list, function($a, $b) {return ($a['id'] == $b['id'] ? 0 : (($a['id'] < $b['id']) ? -1 : 1)); });

(not tested, might be a typo, but that's the jist of it)

answered Jan 13, 2014 at 14:53

Jessica

6,99630 silver badges39 bronze badges

1 Comment

makallio85 Over a year ago

Working solution as well. Implementation is messier than what I was looking for :D

Mark Baker · Accepted Answer · 2014-01-13 14:53:57Z

-1

Either pass by Reference:

public function OrderListById(&$list){
    usort($list, function($a, $b) {return $a['id'] - $b['id'];});
}

or return the sorted list

public function OrderListById($list){
    usort($list, function($a, $b) {return $a['id'] - $b['id'];});
    return $list;
}

edited Jan 13, 2014 at 14:53

answered Jan 13, 2014 at 14:52

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

2 Comments

Mr. Alien Over a year ago

Not the downvoter but seems like you hit the answer button in a hurry

Mark Baker Over a year ago

Gee, how many downvotes am I actually going to get for answering hastily (even if the answer is formatted cleanly now)

Collectives™ on Stack Overflow

Mutlidimensional array not sorting with PHP usort correctly

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related