Call javascript function using php variable

Question

I am using the below code to call the javascript function from php script. Its not working while am adding the php variable in javascript($msg). Please help me to do this.

if ( isset($_GET['Error'])) {
    $msg =$_GET["Error"];
    echo '<script type="script.php">validate("Error",$msg);</script>';
}

<script type="script.php"> isn't a valid value for the type attribute. Change script.php — Aaron W.
– Aaron W., Commented Jan 17, 2014 at 4:07
echo '<script type="script.php">validate("Error",$msg);</script>' can't call a php script. It should read something like <script >validate("Error",$msg);</script> but I'd have to know what the validate function does to be sure anyway, you should leave the type attr off. it's assumed now, but if you had to it's type="text/javascript" — ZombieBunnies
– ZombieBunnies, Commented Jan 17, 2014 at 4:08
<script >validate("Error",$msg);</script> not working for me. — user3085540
– user3085540, Commented Jan 17, 2014 at 4:09

xdazz · Accepted Answer · 2014-01-17 04:12:03Z

1

You have to quote the $msg or it will be syntax error in javascript. And the type is non sense.

Since the msg is from the $_GET, don't forget the escape it.

if ( isset($_GET['Error'])) {
    $msg =$_GET["Error"];
    echo '<script>validate("Error", "'.htmlspecialchars($msg).'");</script>';
}

answered Jan 17, 2014 at 4:12

xdazz

161k38 gold badges255 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Marc B Over a year ago

not good enough, though. by default it'll let ' go through unencoded and STILL break the JS syntax. json_encode(htmlspecialchars(...)) would do the trick.

xdazz Over a year ago

@MarcB Even the ' is quoted by "?

Eric · Accepted Answer · 2014-01-17 04:17:48Z

0

Instead of an inline script, this should work:

<html>
    <head>
        <script type="text/javascript">
            function testMe(x){
                alert(x);
            }
        </script>
    </head>
<body>
<?php
    $phpVar = 'I am a PHP variable';

    echo "<a href=\"#\" onclick=\"javascript:testMe('" . $phpVar . "');\">Click Me</a>";
?>
</body>
<html>

answered Jan 17, 2014 at 4:17

Eric

1,0201 gold badge12 silver badges18 bronze badges

Collectives™ on Stack Overflow

Call javascript function using php variable

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related