How to use if statement right (javascript)

Question

I got this code that works perfectly fine, just like i want it to, but then i want to extend it with else if, but the way i have done my code, that's not possible. Feel free to link some good site to learn from.

if(wallLeft < marioLeft && wallLeftWidth > marioLeft)
{    

}
else
{
    newLeft = marioLeft - 5;
    mario.style.left = newLeft + "px";
}

//else if(wallLeftWidth < marioLeft && wallLeftWidth > marioLeftWidth)
{   }
else
{ //some code }

writing with formatting like: if(something){}else{ makes code look terrible. — Jack L.
– Jack L., Commented Jan 19, 2014 at 20:06
Why do keep reversing the statements, just swap the operators instead — adeneo
– adeneo, Commented Jan 19, 2014 at 20:06
The syntax is if...else if...else. You can have as many else if as you want, but there can only be one else statement at the very end. There are JavaScript reference guides where you can read about the basic syntax: developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/… — Felix Kling
– Felix Kling, Commented Jan 19, 2014 at 20:13

darthmaim · Accepted Answer · 2014-01-19 20:10:29Z

1

Inverse your conditions, writing if(...){}else{...} looks horrible and is really bad practice. Additionally the order is if, else if, else, you cant use else if after else.

if( wallLeft > marioLeft || wallLeftWidth < marioLeft ) {
    newLeft = marioLeft - 5;
    mario.style.left = newLeft + "px";
} else if( wallLeftWidth > marioLeft || wallLeftWidth < marioLeftWidth) {
    //some code 
}

answered Jan 19, 2014 at 20:10

darthmaim

5,1681 gold badge29 silver badges41 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3129452 Over a year ago

That works nice! will accept your answer when i can, (6 minutes)

Hüseyin BABAL · Accepted Answer · 2014-01-19 20:07:38Z

0

Your code is wrong. Try this;

if (wallLeft < marioLeft && wallLeftWidth > marioLeft) {
    newLeft = marioLeft - 5;
    mario.style.left = newLeft + "px";
} else if (wallLeftWidth < marioLeft && wallLeftWidth > marioLeftWidth) { 
    //some code 
}

answered Jan 19, 2014 at 20:07

Hüseyin BABAL

15.6k5 gold badges53 silver badges74 bronze badges

2 Comments

user3129452 Over a year ago

But the code inside the first if-statement i only want to call when the if is false

Hüseyin BABAL Over a year ago

If it is false, it does not enter in first if statement

Collectives™ on Stack Overflow

How to use if statement right (javascript)

2 Answers 2

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related