Javascript validate form OR function

Question

I am trying to ask the user to input at least 1 of the options. From my codes the user need to input all the inputs. Can anyone please check what is wrong with my code?

jsp

<form role="form" method="POST" id="search" action="Servlet" 
      onsubmit="return validateForm();">

    <label>Name</label> 
    <input name="name">

    <label>ID</label> 
    <input name="id">

    <label>no</label> 
    <input name="no">

    <button type="submit">Search</button>
</form>

javascript

function validateForm() {
    var name = document.forms["search"]["name"].value;
    var id = document.forms["search"]["id"].value;
    var no = document.forms["search"]["no"].value;

    if ( (name == null || name == "") || (id == null || id == "") || (no == null && no == "")) {
        alert("Please enter either one to perform search");
        return false;
    }
}

Look your condition: if name is empty OR if id is empty OR no... so if one of those fields is empty it won't continue — Pablo Lozano
– Pablo Lozano, Commented Jan 20, 2014 at 14:20
You have a typo on the onsubmit, there is an h too much. Also, if you don't use strict comparison you can just use if (!name && !id && !no) {...} except if 0 is valid though — René
– René, Commented Jan 20, 2014 at 14:27
Textbox values can not be null so that is a waste of a check. — epascarello
– epascarello, Commented Jan 20, 2014 at 14:30

isherwood · Accepted Answer · 2014-01-20 14:00:26Z

1

Just a little logic adjustment should do the trick:

if ( 
    (name != null || name != "") || 
    (id != null || id != "") || 
    (no != null && no != "") 
) {

This is saying that if any one of the fields has a value, continue.

answered Jan 20, 2014 at 14:00

isherwood

61.4k16 gold badges122 silver badges173 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Muhammad Bekette Over a year ago

why you do the parenthesis thing?! you shouldn't group since you're ORing all the cases ;)

isherwood Over a year ago

I didn't. The OP did. I just reversed the logic.

Muhammad Bekette · Accepted Answer · 2014-01-20 14:28:14Z

0

function validateForm() {
    var name = document.forms["search"]["name"].value;
    var id = document.forms["search"]["id"].value;
    var no = document.forms["search"]["no"].value;

    if ( (name == null || name == "") && (id == null || id == "") && (no == null || no == "")) {
        alert("Please enter either one to perform search");
        return false;
    }
}

or you would do it as @isherwood did. also take care of typos like not closing your input tag should goes like this <input name="no"/> good luck and I hope this would help

answered Jan 20, 2014 at 14:28

Muhammad Bekette

1,4442 gold badges28 silver badges64 bronze badges

Collectives™ on Stack Overflow

Javascript validate form OR function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related