My onclick Javascript function get executed without clicking

Question

I want to do some actions when a button on my page is clicked, but my function executes without clicking on the button and when I check the log using firebug I got "undefine" message. Below is my code snippet so far.

var email = [email protected]   
"<button class='btn btn-warning' onclick ='"+addNote(email)+"' >Add Note</button>"

function addNote(youremail){
     alert("Your email is "+ youremail);
}

With the above code snippet the output will be Your email is [email protected].

See this post: stackoverflow.com/questions/9643311/…. Your code is actually calling the function addNote, not inserting it into the HTML. — maxedison
– maxedison, Commented Jan 21, 2014 at 23:20

Timeout · Accepted Answer · 2014-01-21 23:41:07Z

3

That is because you are calling the function instead of adding it into your string.

"<button class='btn btn-warning' onclick ='addNote(email)' >Add Note</button>"

See this example:

http://jsfiddle.net/sP35v/

edited Jan 21, 2014 at 23:41

answered Jan 21, 2014 at 23:20

Timeout

7,93928 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

fanbondi Over a year ago

will this not treat the parameter as a regular string instead of a variable?

Timeout Over a year ago

@fanbondi No, it will treat it as a variable. If email were a string your event would look like this: onclick="addNote('email')" -> See the difference?

fanbondi Over a year ago

Oh okay I got it,however in the console it says email is not define even-though I defined it before calling it.

Timeout Over a year ago

@fanbondi Did you quote that example email address? Please see the jsfiddle link I included in my post. It will show a working version.

Collectives™ on Stack Overflow

My onclick Javascript function get executed without clicking

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related