jQuery how to replace src url

Question

I have a page that I screen scraped, the scraped page used a relative path for their images and when I load my page, the url of my site is being inserted on the src attr. I need to find some way of replacing my url with the url of the remote site in order for the images and other items that reference it to show up properly on my page.

The script I use to scrape is:

<script src="path_to_jquery.js"></script>
<script>
$document.ready(function() {
 $("#weather").load("http://weather.com" table:nth-child(3)", function() {
  $(this).find("img").each(function() {
   $(this).attr("src").replace('http://my_site.com', 'http://weather.com");
  });
 });
});

I have added the last line with .replace hoping to clean up the problem but so far it is not working. I need to keep the file path so when I replace my url with the target url the rest of the src attr needs to stay there. For example when the page is opened I see the table and all the text fine, but the images fail to load since the do not reside on my server. So I need to update the src attr from this:

http://my_site.com/images/sunny.jpg

to this:

http://weather.com/images/sunny.jpg

Any insight would be appreciated.

How are you getting the HTML across domains?

SLaks
– SLaks

2010-01-24 15:18:48 +00:00
Commented Jan 24, 2010 at 15:18 — SLaks
– SLaks, Commented Jan 24, 2010 at 15:18

SLaks · Accepted Answer · 2010-01-24 15:29:17Z

3

The replace call returns a new string containing the replacements. Your code creates a new string that says my_site.com instead of weather.com, but doesn't do anything with the string.

You need to write the following:

$(this).attr("src", function(index, old) {
    return old.replace('http://my_site.com', 'http://weather.com");
});

edited Jan 24, 2010 at 15:29

answered Jan 24, 2010 at 15:17

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Gumbo Over a year ago

I think it’s rather function(index, old).

Jason Over a year ago

Doesn't seem to be changing the url, the table still loads but it still doesn't update the path.

SLaks Over a year ago

Then the domain part is probably different. Add alert(old) and check what it says.

Jason Over a year ago

I just updated to 1.4 but still no love, also the alert doesn't pop anymore.

Jason Over a year ago

I am retarded! this works, I was staring at this thing for too long and didn't realize I put a https instead of http! Thank you!

wharsojo · Accepted Answer · 2010-01-28 08:33:41Z

1

You have typo in 'http://weather.com"

$document.ready(function() {
 $("#weather").load("http://weather.com" table:nth-child(3)", function() {
  $(this).find("img").each(function() {
    var old_site= $(this).attr("src");
    var new_site= old_site.replace("http://my_site.com", "http://weather.com");
    $(this).attr("src",new_site);
  });
 });
});

answered Jan 28, 2010 at 8:33

wharsojo

1591 silver badge3 bronze badges

Collectives™ on Stack Overflow

jQuery how to replace src url

2 Answers 2

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related