variable inside controller not getting resolved to data resolved by promise

Question

//inside a service PService

this.getPTypes = function(){
        var types = PTypesFactory.get({});
        return types.$promise.then(function(result)
        {
            console.log(result.groups);
            return result.groups;
        });
    }

//inside a controller

$scope.groups = PService.getPTypes();

console log shows correct fetched REST data, but when I do

console.log($scope.groups);

I get

Object {then: function, catch: function, finally: function}

which is promise API instead of the correct resolved data.

Ilan Frumer · Accepted Answer · 2014-01-23 16:12:05Z

1

The problem is that you trying to use a asynchronous function like it was a synchronous one.

then is a method which returns a promise.

when invoking it with a callback that callback would not be invoked immediately, only when the response get back from the server.

You can write it like so:

Service

this.getPTypes = function(callback){
  PTypesFactory.get({}).then(callback);
}

Controller

PService.getPTypes(function(res){
  $scope.groups = res.data;
});

edited Jan 23, 2014 at 16:12

answered Jan 23, 2014 at 16:06

Ilan Frumer

32.4k8 gold badges73 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

James Allardice · Accepted Answer · 2014-01-23 16:05:31Z

0

Promises are used to handle asynchronous operations. The function you pass to the then method is called at some indeterminable point in time. You can't return a value from within it to some other point in execution.

Instead of calling then in your service, just return the promise:

this.getPTypes = function(){
    return PTypesFactory.get({}).$promise;
}

and handle its resolution in the controller:

$scope.groups = PService.getPTypes().then(function(result) {
    console.log(result.groups);
});

answered Jan 23, 2014 at 16:05

James Allardice

166k22 gold badges335 silver badges315 bronze badges

2 Comments

user494461 Over a year ago

moving the .then function to controller doesnt affect the output, its the same as mentioned in Question

James Allardice Over a year ago

@user494461 - Do you even need the then? Return $promise from the service and do $scope.groups = PService.getPTypes();.

Collectives™ on Stack Overflow

variable inside controller not getting resolved to data resolved by promise

2 Answers 2

You can write it like so:

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

You can write it like so:

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related