Adding generic object inside a list

Question

I have these class

Concept
Link, Relation (which extends Concept)
Concepts
Links, Relations (which should extends Concepts)

The class Concepts should have a

private List<? extends Concept> list; //or something similar
addConcept(Concept c); // that should work with a (Link) for the class Links

But this doesn't work the way I tried it... And from searching the Internet, it doesn't look like it can work. How can I make a super class for Links and Relations that include the insertion of a Concept into some sort of memory holder.

This ... doesn't work

public class Concepts{
    protected List<? extends Concept> list = null;
    Concepts(String text) {
    }
    public void add(Concept test) {
        list.add(test);
    }
}
public class Links extends Concepts{
    Links() {
        list = new List<Link>();
    }
    public void add(Link test) {
        list.add(test);
    }
}

.... I want (if possible) to make it impossible to add Relation into Links or Link into Relations

score 2 · Accepted Answer · 2014-01-24 21:53:49Z

You cannot accomplish what you're trying to do. You must wonder why you can't add things of type Concept to your List<? extends Concept>. Here is why:

Consider this case:

List<? extends Concept> list = new List<Link>();

And that you have another class that also extends Concept besides Link, let's call it Link2:

public class Link2 extends Concept { ... }

Then here comes the problem. What if you do:

Link2 myLink2 = new Link2();
list.add(myLink2);// Big problem, remember that your list was instantiated as a list of Links not Link2s.

So that's why you cannot add items to a list of wildcard types like that, because you might try to add something to it that will simply not work with the list type it was instantiated as.

Now, my suggestion for what you're trying to do. Make your base class generic and then your extending classes only have to specify the concrete type it will handle. Something like this:

public class Concepts<T extends Concept> {
     private List<T> list = new List<T>();

     public void add(T test) {
         list.add(test);
     }
}

public class Links extends Concepts<Link> {
}

Marek Urlich · Accepted Answer · 2014-01-24 21:45:43Z

0

My proposition with Generics:

public class AbstractConcepts<T extends Concept> {
    private List<T> list = new ArrayList<>();

    public void add(T test) {
        list.add(test);
    }
}

public class Concepts extends AbstractConcepts<Concept> {
    Concepts(String text) {
    }
}

public class Links extends AbstractConcepts<Link> {
}

In this case, code bellow doesn't compile, so you can't add Relation to Links:

new Links().add(new Relation());

answered Jan 24, 2014 at 21:45

Marek Urlich

161 bronze badge

Comments

dbermudez · Accepted Answer · 2014-01-24 20:47:44Z

0

If I have understood you correctly, a Link is also a Concept (extends Concept), so you can use a List to store both Link and Concept objects, like in this code:

public class Concept{
    Concept(String text) {
    }
}

public class Link extends Concept{

    Link(String text) {
        super(text);
    }
}

import java.util.List;
public class Concepts{
    protected List<Concept> list = null;

    Concepts(String text) {
    }
    public void add(Concept test) {
        list.add(test);
    }
}

public class Links extends Concepts{
    Links(String text) {
        super(text);
    }
    public void add(Link test) {
        list.add(test);
    }
}

Hope it helps

answered Jan 24, 2014 at 20:47

dbermudez

5723 silver badges9 bronze badges

1 Comment

user1106844 Over a year ago

This doesn't do what I need. I want to make it impossible to add the wrong Concept into a List. For example, no Link in Relations and no Relation into Links.

Collectives™ on Stack Overflow

Adding generic object inside a list

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related