passing string 2d array to a function

Question

I am passing string 2d array to a function in a following way. Is it correct or can it be done better ?

#include<iostream>
#include<string>
using namespace std;

void print_name(string name[])
{
    cout<<name[0];
}

int main()
{
    string name[4];
    name[0] = "abc";
    name[1] ="xyz";
    name[2] = "pqr";
    name[3]= "xyq";

    print_name(name);
    return 0;
}

It is better to think of it as an array of strings and not a 2d array even if a string is an array basically. — Daniel
– Daniel, Commented Jan 25, 2014 at 12:13
I don't see any problem here. Maybe better to use vector<string> name(4) here. — herohuyongtao
– herohuyongtao, Commented Jan 25, 2014 at 12:14

Luchian Grigore · Accepted Answer · 2014-01-25 12:14:28Z

2

In C++ a better way is to pass a std::vector as the parameter.

void print_name(const std::vector<std::string>& name)

and

std::vector<std::string> name{"abc", "xyz","pqr","xyq"};

print_name(name);

answered Jan 25, 2014 at 12:14

Luchian Grigore

260k68 gold badges465 silver badges634 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

herohuyongtao Over a year ago

const is needed here? You cannot change it even without const, right?

Luchian Grigore Over a year ago

@herohuyongtao missed the reference.

herohuyongtao Over a year ago

Why not simply void print_name(vector<std::string> name)?

user2249683 Over a year ago

Passing the array is actually simpler (in this case) array[0] is always valid!

Luchian Grigore Over a year ago

@DieterLücking only if you actually pass an array of size at least 1.

|

Sergey Kalinichenko · Accepted Answer · 2014-01-25 12:17:01Z

1

The problem with passing C-style arrays is that the function that you call does not know where it ends. If you must use a fixed-size array, a better approach would be to pass std::array<std::string,4>:

void print_name(std::array<std::string,4>& names) ...

If using std::vector<std::string> is acceptable, it would give your code more flexibility:

void print_name(std::vector<std::string>& names) ...

If none of the above works for you, consider passing the number of array items along with the array, so that your print_name knows how may items it gets:

void print_name(std::string names[], int count) ...

answered Jan 25, 2014 at 12:17

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

1 Comment

user765443 Over a year ago

hmm I think, you are correct I should use vector string... Thx a lot for your response.

Collectives™ on Stack Overflow

passing string 2d array to a function

2 Answers 2

11 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

11 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related