PHP REGEXP match values to array

Question

for example I have this string. #345-6574#56-2432#776-246554#

I want to take all values between sharps.

I tried this but not working

preg_match_all('/^#[\d]+-[\d]+#$/',$string,$output);

John Conde · Accepted Answer · 2014-01-26 17:24:14Z

2

A regex would be unnecessary:

$output = array_filter(explode('#', $string));

answered Jan 26, 2014 at 17:24

John Conde

220k100 gold badges464 silver badges504 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

thanks for answer which is better for performance. regex or explode ?

explode() should be faster. It also is also easier to understand which makes future maintenance easier.

Sabuj Hassan · Accepted Answer · 2014-01-26 17:25:30Z

1

This will do:

preg_match_all('/#(\d+\-\d+)#/',$string,$output);

You use lookahead and lookbehind as well if you want to make sure # to be at the both ends.

preg_match_all('/(?<=#)(\d+\-\d+)(?=#)/',$string,$output);

answered Jan 26, 2014 at 17:25

Sabuj Hassan

39.7k14 gold badges83 silver badges88 bronze badges

I need digits-digits in output array. not sharps. it returns values with sharps.