Javascript Checkbox select/unselect

Question

Im using java script in JSP the problem is i need auto refresh on selectin checkbox it's working fine but on unselecting it's not stopping the auto refresh activity .plz suggest Thanks in advance

function autorefresh() {
    var isChecked = document.getElementById("is_check").checked;
    var time = 0;
    if (isChecked == true) {
        time = setInterval(function () {
            showExport()
        }, 5000);
    } else if (isChecked == false) {
        clearInterval(time);
    }
}

Declare time outside of the function. Also note that you can reduce if (x == true) {...} else if (x == false) {...} to if (x) {...} else {...}. — Felix Kling
– Felix Kling, Commented Jan 28, 2014 at 6:13
@FelixKling - Why? And by the way @NaimFS, setInterval(function () { showExport() }, 5000); --> setInterval(showExport, 5000); — Derek 朕會功夫
– Derek 朕會功夫, Commented Jan 28, 2014 at 6:13
@FelixKling - Is it because autorefresh is called multiple times? (although he never said it in his question or I missed it probably) — Derek 朕會功夫
– Derek 朕會功夫, Commented Jan 28, 2014 at 6:16
@Derek朕會功夫: Why, it makes total sense: If the checkbox is checked, start the interval. If it is unchecked, stop it, etc. Of course it should be reexecuted when the checkbox is checked again. — Felix Kling
– Felix Kling, Commented Jan 28, 2014 at 6:22

Somnath Kharat · Accepted Answer · 2014-01-28 06:26:53Z

1

Define time variable as global:

window.time=0;     //global declaration
function autorefresh() {
    var isChecked = document.getElementById("is_check").checked;
    if (isChecked == true) {
        time = setInterval(function () {
            showExport()
        }, 5000);
    } else if (isChecked == false) {
        clearInterval(time);
    }
}

answered Jan 28, 2014 at 6:26

Somnath Kharat

3,5952 gold badges31 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ram · Accepted Answer · 2014-01-28 06:14:50Z

1

That's because you are defining the time variable inside the autorefresh context, so it no longer stores the ID of the interval, you should define it outside of the function.

answered Jan 28, 2014 at 6:14

Ram

145k16 gold badges174 silver badges201 bronze badges

Collectives™ on Stack Overflow

Javascript Checkbox select/unselect

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related