Facing issue in getting the largest integer from Array

Question

Receiving 5,9,7 as output.. Where as the expected should be only 9..Below is the code:

public class GreatestNoInArray {  
    public static void main(String[] args) {                
        int a[]= new int[] {1,2,5,9,7};        
        int big=a[0];        
        for (int i=1; i<a.length; i++){        
            if (big<a[i])        
                big=a[i];                   
            System.out.println(a[i]);        
        }
    }    
}

Please help

Jigar Joshi · Accepted Answer · 2014-01-29 18:03:58Z

7

for expected answer you need to print big (not a[i]) out side of loop

edited Jan 29, 2014 at 18:03

answered Jan 29, 2014 at 17:54

Jigar Joshi

241k42 gold badges409 silver badges446 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

knoight · Accepted Answer · 2014-01-29 17:55:27Z

4

public class GreatestNoInArray {
  public static void main(String[] args) {
      int a[]= new int[] {1,2,5,9,7};
      int big=a[0];

      for (int i=1; i<a.length; i++){
          if (big<a[i])       
              big=a[i];
          }   
      System.out.println(big);
  }
}

answered Jan 29, 2014 at 17:55

knoight

4798 silver badges18 bronze badges

1 Comment

user3220565 Over a year ago

How silly was that.. I declared a variable for the largest and m printing i instead.. Thanks a lot mate..

Alvin Bunk · Accepted Answer · 2014-01-29 18:05:25Z

0

code should be like this:

public class GreatestNoInArray {  
    public static void main(String[] args) {                
        int a[] = new int[] {1,2,5,9,7};        
        int big = a[0];        
        for (int i=1; i<a.length; i++){        
            if (big < a[i])        
                big = a[i];                   
            //System.out.println(a[i]);        
        }
    System.out.println("Big: " + big);
    }    
}

This works!

answered Jan 29, 2014 at 18:05

Alvin Bunk

7,8123 gold badges31 silver badges48 bronze badges

Collectives™ on Stack Overflow

Facing issue in getting the largest integer from Array

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related