Extending Ember.ArrayProxy

Question

How do I extend Ember.ArrayProxy? I have tried the following:

Ember.ArrayProxy.reopenClass({
  flatten: function(){
    var r = [];

    this.forEach(function(el) {
      r.push.apply(r, Ember.isArray(el)  ? el.flatten() : [el]);
    });

    return r;        
  }
});

But ended up writing the following solution:

// Source: https://gist.github.com/mehulkar/3232255
Array.prototype.flatten = Ember.ArrayProxy.prototype.flatten =function() {
  var r = [];

  this.forEach(function(el) {
    r.push.apply(r, Ember.isArray(el)  ? el.flatten() : [el]);
  });

  return r;
};

Is there something I'm missing in the former example? I'm trying to stick with Ember's methodology, so I would prefer not to use the later.

Kingpin2k · Accepted Answer · 2014-01-31 14:42:46Z

1

If you're using flatten on instances of ArrayProxy you'd want to use reopen, and not reopenClass. reopenClass adds the method to the class itself, aka you could call Em.ArrayProxy.flatten()

http://emberjs.jsbin.com/OqUFObeg/1/edit

answered Jan 31, 2014 at 14:42

Kingpin2k

47.4k10 gold badges80 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

alvincrespo Over a year ago

I tried using this on ArrayProxy but the problem is that when I use .mapBy, I get an Array and it doesn't contain the flatten method. I've tried reopening the Ember.NativeArray class, but that doesn't really solve my problem.

Kingpin2k Over a year ago

It sounds like you just want to add flatten to the array prototype

alvincrespo Over a year ago

Yeah, thats what I'm debating. In an Ember application, am I supposed to extend the Array prototype or work with the built-in Ember classes? I'm having trouble trying to see where it should go.

Kingpin2k Over a year ago

If you just plan on using it on ember types only it makes sense to just add it to ember types, but if you want it to work on plain ol' array's you'd want to extend the Array prototype

alvincrespo Over a year ago

I would prefer to only have it on Ember types, but unfortunately the mapBy function in Ember returns a plain Array. From the documentation it seems like it should be returning an ArrayProxy.

Collectives™ on Stack Overflow

Extending Ember.ArrayProxy

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related