Asp.Net MVC SelectList Refactoring Question?

Question

I am currently refactoring our messy controllers. We have a lot of SelectLists in our controllers. I want a way make it easier to maintain our code base. What would be a good solution a Factory Method, Interface or Base Class? We a lot of these methods floating around our code.

private SelectList getRateContract(IEnumerable items)
    {
        return new SelectList(items, Resources.RSINET.RateContractID, Resources.RSINET.ContractName);
    }

Dan Atkinson · Accepted Answer · 2010-01-27 22:57:31Z

1

For a start, if they lie in the controller, these methods should at least be decorated with the NonAction attribute.

The SelectList creation would, in my opinion, be done in the view model, but not everyone uses models in the same way (I know Microsoft don't). You should probably have a call to your model that creates this selectlist. That way, the controller stays in... well, control of the application flow, and the model does its job of containing the data.

answered Jan 27, 2010 at 22:57

Dan Atkinson

11.8k14 gold badges89 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user154366 Over a year ago

I used a generic typesafe select list to add with my problems.

Collectives™ on Stack Overflow

Asp.Net MVC SelectList Refactoring Question?

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related