Adding every element in a ArrayList to a JFrame

Question

So I want to add some text to a window.

I added the text in a ArraList like this:

ArrayList<String> Text = new ArrayList<String>();
Text.add("text1");
Text.add("text2");
...
Text.add("text*n*");

I now want to add these items into a JFrame. Now, I am pretty new to programming, so there is probably a better solution than this. But here is what I tried (I am using a for loop, because I think this is also the easiest way for me to manage the bounds of the labels:

for(int i = 0; i<Text.size();i++){
    JLabel jl = new JLabel(names.get(i));

    jl.setBounds(50,100+20*i,200,50);
    this.add(jl);

}

But only the last element in the ArrayList is added to the JFrame (text*n*). Not all of them. How can I get every element in the arraylist to show in the jframe? Maybe I shouldn't use JFrame?

Why are you using names.get(i) rather than Text.get(i)?

Jon Skeet
– Jon Skeet

2014-02-02 16:48:30 +00:00
Commented Feb 2, 2014 at 16:48 — Jon Skeet
– Jon Skeet, Commented Feb 2, 2014 at 16:48

Hovercraft Full Of Eels · Accepted Answer · 2014-02-02 17:21:12Z

3

It sounds like you want to use a JList, not a grid of JLabel.

i.e.,

DefaultListModel<String> listModel = new DefaultListModel<String>();
JList<String> myJList = new JList<String>(listModel);

// assuming you have an array of String or ArrayList<String> called texts
for (String text : texts) {
  listModel.addElement(text);
}

JScrollPane listScrollPane = new JScrollPane(myJList);

// then add the listScrollPane to your GUI

Also:

Please learn and follow Java naming rules. Variable names should begin with a lower case letter, so "text" not Text.
And you should know that every time someone uses a null layout and setBounds(...) a puppy dies. Please don't be cruel to puppies, and don't create rigid hard to maintain and upgrade GUI's. Learn and use the Swing layout managers. You won't regret this, and neither will the puppies.

answered Feb 2, 2014 at 17:21

Hovercraft Full Of Eels

286k25 gold badges267 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Smitty · Accepted Answer · 2014-02-02 16:59:57Z

2

You need a layout, otherwise they are added on top of each other. Try adding everything to a JPanel and only add the panel to the frame at the end.

JFrame frame = new JFrame("title");
JPanel panel = new JPanel();
// Y_AXIS means each component added will be added vertically
panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));

for (String str : Text) {
   JLabel j1 = new JLabel(str);
   panel.add(j1);
}

frame.add(panel);
frame.pack();
frame.setVisible(true);

answered Feb 2, 2014 at 16:59

Smitty

4032 silver badges13 bronze badges

2 Comments

Zahand Over a year ago

Thank you. One final question. Everything is added to the top left corner. How can I choose were to put it?

Smitty Over a year ago

Depends where/how you want to puts things. Without knowing this I can't really help much. There are a bunch of other layout managers that you can choose: layouts

Rakesh KR · Accepted Answer · 2014-02-02 16:50:08Z

0

Try with Replace names.get(i) as Text.get(i)

OR Try,

for(String str : Text){
    JLabel jl = new JLabel(str);
}

answered Feb 2, 2014 at 16:50

Rakesh KR

6,5475 gold badges45 silver badges58 bronze badges

Comments

MrMike · Accepted Answer · 2014-02-02 16:50:28Z

0

Try this:

String output = "";
for(int i = 0; i<Text.size();i++)
{
    output += Text.get[i] + "\n";

}
JLabel jl = new JLabel(output);

This will create a string named output that will add the text from each index, followed by creating a new line. Then at the end, the full string will be added to the JLabel. The only downside to this method is that one label will contain ALL of the text.

answered Feb 2, 2014 at 16:50

MrMike

1,5402 gold badges17 silver badges24 bronze badges

Comments

Martin · Accepted Answer · 2016-02-15 17:41:32Z

0

JLabel jl = new JLabel(names.get(i));

Here you always construct a new object for j1, and after the loop you just have the latest object.

edited Feb 15, 2016 at 17:41

answered Feb 2, 2014 at 16:52

Martin

2391 silver badge16 bronze badges

Collectives™ on Stack Overflow

Adding every element in a ArrayList to a JFrame

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related