"Garbage" values in 2D array when trying to print via function

Question

I'm making a classic tic-tac-toe type game but with the board size defined by the user.

When trying to print the board (with asterisks representing open spaces) after the user specifies a size for the board, I'm only getting what seem to be garbage values.

#include <iostream>
#include <string>
using namespace std;

const int BOARD_MAX = 10;
const int BOARD_MIN = 3;

bool sizecheck(int);
void displayBoard(char [][BOARD_MAX], int);

int main(void)
{
    int boardsize, i, j;
    char grid[BOARD_MAX][BOARD_MAX];

    cout << "Please enter the size of the board (" << BOARD_MIN << " - " << BOARD_MAX << "): ";
    cin >> boardsize;

    if ((sizecheck(boardsize)) == false)
    {
        do
        {
            cout << "Must be a number between " << BOARD_MIN << " and " << BOARD_MAX << ". Try again." << endl;
            cout << "Please enter the size of the board (" << BOARD_MIN << " - " << BOARD_MAX << "): ";
            cin >> boardsize;

            sizecheck(boardsize);
        }

        while ((sizecheck(boardsize)) == false);
    }

    for (i = 0; i < boardsize; i++)
    {
        for (j = 0; i < boardsize; i++)
        {
            grid[i][j] = '*';
        }
    }

    displayBoard(grid, boardsize);

    return 0;
}

bool sizecheck(int fboardsize)
{
    if ((fboardsize > BOARD_MAX) || (fboardsize < BOARD_MIN))
    {
        return false;
    }

    else
    {
        return true;
    }
}


void displayBoard(char fgrid[][BOARD_MAX], int fboardsize)
{
    int i, j;

    for (i = 0; i < (fboardsize); i++)
    {
        for (j = 0; j < (fboardsize); j++)
        {
            cout << fgrid[i][j];
        }

        cout << endl;
    }
}

Output:

out http://puu.sh/6IfHU.png

The program is obviously a work in progress; I'm just having trouble with the printing of the array after using a function. If i try to print without the function, it works fine. I'm having a hard time figuring out what's going wrong.

Sorry for the super basic question; I'm very new to C++ and programming in general and am quite stumped.

Thanks!

rAndom69 · Accepted Answer · 2014-02-03 06:28:44Z

1

check you grid init cycle...

for (i = 0; i < boardsize; i++)
{
    for (j = 0; i < boardsize; i++)

answered Feb 3, 2014 at 6:28

rAndom69

7754 silver badges7 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

korina Over a year ago

Thanks for answering my question, and sorry for wasting your time! It slipped my notice at least 45 times. :)

rAndom69 Over a year ago

happens :) take a look at c++ and stuff like for_each, it helps to reduce potential mistakes.

twin · Accepted Answer · 2014-02-03 06:29:00Z

0

There is a typo in your code where you initialize the board: It should read

for (i = 0; i < boardsize; i++)
{
    for (j = 0; j < boardsize; j++)
    {
        grid[i][j] = '*';
    }
}

answered Feb 3, 2014 at 6:29

twin

1,66913 silver badges11 bronze badges

1 Comment

korina Over a year ago

Oh lord, I feel silly! I guess sometimes it takes someone else to look at your code to point out dumb mistakes. Thanks!

Collectives™ on Stack Overflow

"Garbage" values in 2D array when trying to print via function

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related