Multiple powershell switch parameters - can it be optimized?

Question

I am trying to write a simple wrapper that accept one parameter for the output. This is how it looks now

function Get-data{
param (
    [switch]$network,
    [switch]$profile,
    [switch]$server,
    [switch]$devicebay
 )

    if ($network.IsPresent) { $item = "network"}
    elseif ($profile.IsPresent) {$item = "profile"}
    elseif ($server.IsPresent) {$item = "server"}
    elseif ($devicebay.IsPresent){$item = "devicebay"}

    $command = "show $item -output=script2"
}

Clearly this could be optimize but I am struggling to wrap my head around on how I can achieve it .Is there some easy way to ensure only single parameter is accepted and used without resorting to multiple elseif statements?
Also I would like to provide array of paramters instead doing it the way it is done at the moment.

mjolinor · Accepted Answer · 2014-02-04 01:11:52Z

17

Another thing you could do instead of all those switch parameters is to use a [ValidateSet]

function Get-Data{
    [cmdletbinding()]

    param(
        [Parameter(Mandatory=$true)]
        [ValidateSet('Network','Profile','Server','DeviceBay')]
        [string]$Item
    )

    Switch ($Item){
        'network' {'Do network stuff'}
        'profile' {'Do profile stuff'}
        'server' {'Do server stuff'}
        'devicebay' {'Do devicebay stuff'}
    }
}

edited Feb 4, 2014 at 1:11

mjolinor

68.7k7 gold badges118 silver badges141 bronze badges

answered Feb 3, 2014 at 17:49

E.V.I.L.

2,16613 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Hunter Eidson · Accepted Answer · 2014-02-03 13:28:13Z

Probably not the most elegant solution, but using parametersets makes powershell do some of the work for you:

#requires -version 2.0

function Get-data {
    [cmdletbinding()]

    param(
        [parameter(parametersetname="network")]
        [switch]$network,
        [parameter(parametersetname="profile")]
        [switch]$profile,
        [parameter(parametersetname="server")]
        [switch]$server,
        [parameter(parametersetname="devicebay")]
        [switch]$devicebay
    )

    $item = $PsCmdlet.ParameterSetName

    $command = "show $item -output=script2"
}

This example will error out if you don't provide one of the switches, but you could probably provide an extra switch that does nothing or errors more gracefully if you want to account for that case...

jpaugh · Accepted Answer · 2018-07-30 21:10:16Z

8

You can add the [cmdletbinding()] keyword so you get $PSBoundParameters, and use that for a switch pipeline:

function Get-data{
    [cmdletbinding()]

    param (
        [switch]$network,
        [switch]$profile,
        [switch]$server,
        [switch]$devicebay
     )
     Switch ($PSBoundParameters.GetEnumerator().
      Where({$_.Value -eq $true}).Key)
     {
       'network'    { 'Do network stuff' }
       'profile'    { 'Do profile stuff'  }
       'server'     { 'Do server stuff' }
       'devicebay'  { 'Do devicebay stuff' }
     }
}

edited Jul 30, 2018 at 21:10

jpaugh

7,1845 gold badges46 silver badges94 bronze badges

answered Feb 3, 2014 at 15:00

mjolinor

68.7k7 gold badges118 silver badges141 bronze badges

Comments

nitzel · Accepted Answer · 2017-11-07 10:06:29Z

1

Since you want only one switch to be enabled, an enum might help you. This way, you're not using a switch but a standard parameter - still, the user of the cmdlet can use TAB to autocomplete the values that may be entered.

Just set the type of the parameter to your enum.

answered Nov 7, 2017 at 10:06

nitzel

1,92516 silver badges15 bronze badges

1 Comment

jpaugh Over a year ago

And, it could well accept a list of enums (unlike in OP's case), to perform multiple actions. Simple, and elegant!

Collectives™ on Stack Overflow

Multiple powershell switch parameters - can it be optimized?

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related