Doubly linked node constructor in c++

Question

I am trying to make a node for a doubly linked list in c++, but experiencing some problems with the constructor. I have the following simplyfied header file:

class Node{
public:
    Node();
private:
    int data;
    Node* next;
    Node* previous;
};

My .cpp file looks as the following:

#include <iostream>
#include <cstdlib>

using namespace std;

int data;
Node* next;
Node* previous;

Node::Node(){
    data = 0;
    next = NULL;
    previous = NULL;
}

I get the following error when compiling this: "Node does not name a type."

I have also tried to use 'struct' to create the Node:

struct Node{
     int data;
     Node* next;
     Node* previous;
}

But this however gives me another error on the constructor in the cpp file: "definition of implicitly-declared ...."

How can I make this program compile without error messages by using a constructor and variables, and what am I doing wrong?

Mike Seymour · Accepted Answer · 2014-02-03 13:50:36Z

3

You haven't included the header that defines Node.

answered Feb 3, 2014 at 13:50

Mike Seymour

256k30 gold badges467 silver badges658 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Wonderwoman Over a year ago

I feel extremly embarrassed for forgetting this. Thank you very much, this solved the problem.

Vlad from Moscow · Accepted Answer · 2014-02-03 13:51:50Z

1

You have to include the header with Node definition in your cpp module. Also I think these statements in the cpp module

int data;
Node* next;
Node* previous;

must be deleted.

You could define the constructor inside the class definition. I would define it as

class Node{
public:
    Node( int data, Node *next = 0, Node *previous = 0 ) 
        : data( data ), next( next ), previous( previous )
    {
    }
private:
    int data;
    Node* next;
    Node* previous;
};

answered Feb 3, 2014 at 13:51

Vlad from Moscow

313k27 gold badges204 silver badges358 bronze badges

Collectives™ on Stack Overflow

Doubly linked node constructor in c++

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related