NullPointerException: adding JButtons in an array & panel

Question

JButton buttonArray[][] = new JButton [6][7];
JPanel grid;
JButton b1;


grid.setLayout (new GridLayout(6,7,0,0));

    slot = new ImageIcon ("gameboard.png");

    for (int i = 0; i < 6; ++i)
    {
        for (int j = 0; j < 7; ++j)
        {
            b1 = new JButton (slot);
            buttonArray[i][j] = b1;
            buttonArray[i][j].setContentAreaFilled (false);
            buttonArray[i][j].setBorderPainted (false);
            grid.add(buttonArray[i][j]);
        }
    }

I am getting a NullPointerException which points to the grid.setLayout (new GridLayout(6,7,0,0)); part and to the new GameBoard(); which is in the main method at the bottom.

I add grid panel t o another panel as well, together with other panels:

panel = new JPanel();
        panel.setLayout(new BorderLayout());
        panel.add("North", panel1);
        panel.add("Center",grid);
        panel.add("South",panel2);
        add(panel);

I did initialize grid and buttonArray[][] already. What am I missing?

Where are you initializing grid? You haven't shown that. If you're not, then presumably it still has a null value... — Jon Skeet
– Jon Skeet, Commented Feb 8, 2014 at 17:03
@user3026693: the JVM is telling you different. Believe the JVM. Show us where you initialize grid. — Hovercraft Full Of Eels
– Hovercraft Full Of Eels, Commented Feb 8, 2014 at 17:05

Hovercraft Full Of Eels · Accepted Answer · 2014-02-08 17:03:44Z

3

The grid variable is null as it has never been assigned an object. You need to either give it a new something or pass in its value via a setter method or constructor parameter.

More important than the actual solution to your current problem, is the knowledge of how to debug most common NullPointerExceptions. When you encounter a NullPointerException, you should carefully check all the variables on the line that throws the exception, find out which one is null, and then track back in your program to find out why it's null when you though otherwise.

answered Feb 8, 2014 at 17:03

Hovercraft Full Of Eels

286k25 gold badges268 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3026693 Over a year ago

Thanks I'm able to fix it, I guess I just need to code a little bit cleaner

Hovercraft Full Of Eels Over a year ago

@user3026693: see edit to answer. Learning to debug NPE's is a necessary skill to have as you will encounter many of these in the future.

Mureinik · Accepted Answer · 2014-02-08 17:04:22Z

3

You didn't initialize the grid variable:

JPanel grid; // null since it wasn't initialized
JButton b1;

grid.setLayout (new GridLayout(6,7,0,0));

You should just create some object there:

JPanel grid = new JPanel();
JButton b1;


grid.setLayout (new GridLayout(6,7,0,0));

answered Feb 8, 2014 at 17:04

Mureinik

316k54 gold badges400 silver badges405 bronze badges

1 Comment

user3026693 Over a year ago

Well this is rather embarrassing, I should've looked through my code further and more carefully but thank you for the answer!!

Collectives™ on Stack Overflow

NullPointerException: adding JButtons in an array & panel

2 Answers 2

2 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related