PHP: Function Not Working

Question

<?php


$V = "Stormy";
$W = "Heavy thunderstorms";

function getMyString($SentenceSrc)
{
    if ((strpos($SentenceSrc,'Heavy thunderstorms')!== true) OR (strpos($SentenceSrc,'Heavy t-storms')!== true))
     $SentenceVariable = "Rains with gusty winds";

    elseif ((strpos($SentenceSrc,'Sun')!== true) OR (strpos($SentenceSrc,'sun')!== true))
        $SentenceVariable = "Sunny";
    elseif ((strpos($SentenceSrc,'Stormy')!== true))
        $SentenceVariable = "Stormy";
    else
        $SentenceVariable = "Partly cloudy ";

    return $SentenceVariable;
}



echo getMyString($V);
echo getMyString($W);


?>

This is my code. The output should be:

StormyRains with gusty winds

But instead, it only reads the first part of the condition, and returns it True, when it is false.

my getMyString($SentenceSrc) is supposed to find a string within a given string and return a weather condition whenever the given string returns true.

strpos returns a number (the position) or false (never true), I don't know if comparing strpos()!==true is doing something, try comparing to false — Pablo Martinez
– Pablo Martinez, Commented Feb 11, 2014 at 9:42

Craftein · Accepted Answer · 2014-02-11 09:44:41Z

1

I've changed your !== true to > -1

<?php
$V = "Stormy";
$W = "Heavy thunderstorms";

function getMyString($SentenceSrc)
{
    if ((strpos($SentenceSrc,'Heavy thunderstorms') > -1) OR (strpos($SentenceSrc,'Heavy t-storms') > -1))
        $SentenceVariable = "Rains with gusty winds";
    elseif ((strpos($SentenceSrc,'Sun') > -1) OR (strpos($SentenceSrc,'sun') > -1))
        $SentenceVariable = "Sunny";
    elseif ((strpos($SentenceSrc,'Stormy') > -1))
        $SentenceVariable = "Stormy";
    else
        $SentenceVariable = "Partly cloudy ";

    return $SentenceVariable;
}

echo getMyString($V);
echo '<br />';
echo getMyString($W);
?>

answered Feb 11, 2014 at 9:44

Craftein

7625 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Clary Over a year ago

Thanks! Can I ask for an explanation to this?

Satish Sharma Over a year ago

+1 for quick answer. i also posted the answer but because you have given first i have deleted my post

Craftein Over a year ago

@Clary If found something, return the location of the matching phrase/substring and if none, return false. But for some reason, === false is not working on mine so we just look for int greater than -1 because the start of the string is 0. so yeah.

GuyT Over a year ago

That's because you're checking different things there. If you're checking for > -1 you're checking for a true. If you do a check on ===false you're checking on a false. Execute following code: <?php if (strpos("test", "test") > -1) echo "success"; if (strpos("test", "test") === false) echo "success"; ?> The first one will return success because 'test' is in the string 'test'. The second one will fail because 'test' is in 'test' and therefor will not return false.

Bart Friederichs · Accepted Answer · 2014-02-11 09:42:01Z

0

strpos($a, $b)!==true is always false, because strpos returns an integer when the string is found.

Use strpos($a, $b) === false instead.

answered Feb 11, 2014 at 9:42

Bart Friederichs

33.8k16 gold badges112 silver badges219 bronze badges

1 Comment

Bart Friederichs Over a year ago

For the boolean logic to keep working, you'll have to change the OR to AND also.

William Buttlicker · Accepted Answer · 2014-02-11 09:42:03Z

0

It is functioning the way you have written it. strpos never returns true. It eigther returns position of the needle if found or false.

So your first condition always correct.

What you need to do is:

if ((strpos($SentenceSrc,'Heavy thunderstorms')=== false) OR (strpos($SentenceSrc,'Heavy t-storms')=== false))

answered Feb 11, 2014 at 9:42

William Buttlicker

6,0005 gold badges36 silver badges59 bronze badges

Comments

CodeBird · Accepted Answer · 2014-02-11 09:45:45Z

0

try this

    function getMyString($SentenceSrc)
    {
        if (stristr($SentenceSrc,'Heavy thunderstorms') || stristr($SentenceSrc,'Heavy t-storms')){
            $SentenceVariable = "Rains with gusty winds";
        }
        elseif (stristr($SentenceSrc,'Sun') || stristr($SentenceSrc,'sun')){
            $SentenceVariable = "Sunny";
        }
        elseif (stristr($SentenceSrc,'Stormy')){
            $SentenceVariable = "Stormy";
        }
        else {
            $SentenceVariable = "Partly cloudy ";
        }
        return $SentenceVariable;
    }

answered Feb 11, 2014 at 9:45

CodeBird

3,8132 gold badges22 silver badges38 bronze badges

Collectives™ on Stack Overflow

PHP: Function Not Working

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related